Hi all, as you can see from github emails there is an ongoing proposal to add "checkstyle" plugin to BookKeeper build. I am really in favour of this change. It is already used in DistributedLog and it will ease the review, preventing us from writing comments for minor typos.
https://github.com/apache/bookkeeper/issues/230 https://github.com/apache/bookkeeper/issues/230 Thanks to David (I hope he is subscribed to this list) we will be able to add this kind of support soon. My concern is that this change will make us change all big pull requests. We should decide when to get checkstyle in: 1) as soon as possible (after review of the patch) 2) before 4.5 release, as last step 3) after merging biggest changes (Twitter changes and Salesforce changes) which are waiting for review/merge 4) defer to the start of 4.6 My proposal is to defer to the start of 4.6, the only problem is that David will be doing a big effort to keep the patch in synch with the actual master -- Enrico
