[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059857#comment-16059857
 ] 

Zhimeng Shi commented on BOOKKEEPER-1099:
-----------------------------------------

Thanks for Sijie's explanation in email. I guess I should reply here rather 
than in email directly.

When I start working on Salesforce as first time touch open source world, I 
really don't understand why we use a so compplicated Puppet system to setup 
machines. why not move all the service related setup logic into the deployment 
step etc. I think Sijjie's explanation gave me some sight about the reasons. 

Anyway, for this issue, even we want be flexible on the working disk, the 
machine prepare setup like Puppet or other system should only create the root 
working folder (in Salesforce that folder is /xxx/sfsdata). Then let the 
service self create sub folders (journal folder and ledger folders here) needed 
under it. Because that way can decouple the service internal file structure and 
logic from the machine/disk setup process. If in future Bookkeeper want to 
fully change the folder structure, you don't need modify the Puppet model for 
the machine disk prepare. 

Is that make sense? Or is it true in Twitter that you use Puppet to create all 
the sub folders?

> Make bookie automatically create folders on new machine.
> --------------------------------------------------------
>
>                 Key: BOOKKEEPER-1099
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1099
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>            Reporter: Zhimeng Shi
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When bookie start and found it need run bookie format to create folders it 
> should do that automatically. That way will make new machine deployment and 
> machine replacement process much simpler without manually call the 
> bookieformat command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to