[
https://issues.apache.org/jira/browse/BOOKKEEPER-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034680#comment-16034680
]
Hudson commented on BOOKKEEPER-1090:
------------------------------------
SUCCESS: Integrated in Jenkins build bookkeeper-master #1772 (See
[https://builds.apache.org/job/bookkeeper-master/1772/])
BOOKKEEPER-1090: Use LOG.isDebugEnabled() to avoid unexpected (eolivelli: rev
5f945f8a02f5171608810eb002443193c3eb058c)
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ExplicitLacFlushPolicy.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SASLClientAuthProvider.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SaslClientState.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationEnableCb.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperWatcherBase.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieInfoReader.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerIdGenerator.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/TopologyAwareEnsemblePlacementPolicy.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SASLClientProviderFactory.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SaslServerState.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SASLBookieAuthProviderFactory.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/TGTRefreshThread.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SASLBookieAuthProvider.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadLacOp.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/WeightedRandomSelection.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LongZkLedgerIdGenerator.java
* (edit)
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/GetBookieInfoProcessorV3.java
> Use LOG.isDebugEnabled() to avoid unexpected allocations
> --------------------------------------------------------
>
> Key: BOOKKEEPER-1090
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1090
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Minor
> Fix For: 4.5.0
>
>
> Using {{LOG.debug(...)}} can lead to multiple unexpected memory allocation,
> even when the logger it's turned off.
> For example, {{int}} and {{long}} parameter are boxed into {{Integer}} and
> {{Long}} objects and the var-arg parameters are using an {{Object[]}} to hold
> them.
> We should guard all usages of {{LOG.debug()}} with the {{if
> (LOG.isDebugEnabled()}} guard.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
