[ https://issues.apache.org/jira/browse/BOOKKEEPER-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032711#comment-16032711 ]
ASF GitHub Bot commented on BOOKKEEPER-1084: -------------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/172 > Make variables finale if necessary > ---------------------------------- > > Key: BOOKKEEPER-1084 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1084 > Project: Bookkeeper > Issue Type: Improvement > Reporter: Sijie Guo > Assignee: Sijie Guo > Fix For: 4.5.0 > > > Merge commit > {code} > commit daffc8460670cd15994bb8650add3be5a9dc2eef > Author: Sijie Guo <sij...@twitter.com> > Date: Thu Apr 18 17:54:55 2013 -0700 > make logger as a static variable > not all logger in bookkeeper & hedwig are static. some class like > PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so > this task is to make logger as a static variable if it didn't. > with benefit, cleaning up the imports when touching that file. > RB_ID=141138 > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)