[ https://issues.apache.org/jira/browse/BOOKKEEPER-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011529#comment-16011529 ]
ASF GitHub Bot commented on BOOKKEEPER-1066: -------------------------------------------- Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/153 Interesting and on the paper sounds great. But do we have any perf testing or benchmark? I believe we need to have a benchmark / ref to run and compare any perf improvements. I have seen extremely interesting results for changes which made absolute sense on paper. :) > Introduce GrowableArrayBlockingQueue > ------------------------------------ > > Key: BOOKKEEPER-1066 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1066 > Project: Bookkeeper > Issue Type: Improvement > Reporter: Matteo Merli > Assignee: Matteo Merli > Priority: Minor > Fix For: 4.5.0 > > > In multiple places, (eg: journal, ordered executor, etc..), we are using > {{LinkedBlockingQueue}} instances to pass objects between threads. > The {{LinkedBlockingQueue}} differs from the {{ArrayBlockingQueue}} in that > it doesn't require to define a max queue size, though, being implemented with > a linked list, it requires to allocates list nodes each time an item is added. > We can use a {{GrowableArrayBlockingQueue}} that behaves in the same way as > the {{LinkedBlockingQueue}}, but it's implemented with an array that can be > resized when the queue reaches the capacity. -- This message was sent by Atlassian JIRA (v6.3.15#6346)