[
https://issues.apache.org/jira/browse/BOOKKEEPER-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996431#comment-15996431
]
ASF GitHub Bot commented on BOOKKEEPER-1046:
--------------------------------------------
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/136
Overall is OK for me, one little change
can you drop the old method as it is no more used ?
`public void submitOrdered(Object orderingKey, SafeRunnable r) {`
BK code does not use it directly, it is an internal class.
> Avoid long to Long conversion in OrderedSafeExecutor task submit
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-1046
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1046
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Trivial
> Fix For: 4.5.0
>
>
> When submitting tasks to an OrderedSafeExecutor, most of the time a ledger id
> is being passed. Given that the method accepts and Object, the primitive long
> is boxed into a Long allocated on the heap.
> Added specific method overload to directly accept longs as the key in the
> OrderedSafeExecutor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
