GitHub user merlimat opened a pull request:

    https://github.com/apache/bookkeeper/pull/135

    BOOKKEEPER-1045: Execute tests in different JVM processes

    The current Maven Surefire configuration is using:
    ```xml
    <forkMode>always</forkMode>
    ```
    
    This is a deprecated config and apparently it's not creating new processes 
for each test as intended.
    
    Currently the tests are leaking a big number of files and threads due to 
several reasons:
     * Tests that instantiate bookies and call shutdown() without calling 
start() before are creating and initializing the ledger storage but not closing 
it, leaking threads and several fds
      * ZooKeeperClient sometimes doesn't shutdown the zk handle if the test 
completes too quickly, leaking sockets.
     * Several tests are passing bad config, so the bookie/client start gets 
exception (on purpose) and then doesn't clean up some partial objects.
     * ...
    
    That make running the test suite to be dependent on ulimit of the machine.
    
    Until we can fix (almost) all the test to do proper cleanup, we should make 
maven to run tests in separated processes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merlimat/bookkeeper bk-1045-test-forks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit da0aece16a91550130854aa23dd2e5b5efec175a
Author: Matteo Merli <mme...@apache.org>
Date:   2017-05-04T00:39:50Z

    BOOKKEEPER-1045: Execute tests in different JVM processes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to