[
https://issues.apache.org/jira/browse/BOOKKEEPER-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo resolved BOOKKEEPER-1038.
-----------------------------------
Resolution: Fixed
Issue resolved by merging pull request 131
[https://github.com/apache/bookkeeper/pull/131]
{noformat}
commit 83d5d9e2a51c8c135bfc97d3831beccebe11a69a
Author: eolivelli <eolive...@apache.org>
AuthorDate: Thu Apr 20 10:55:16 2017 -0700
Commit: Sijie Guo <si...@apache.org>
CommitDate: Thu Apr 20 10:55:16 2017 -0700
BOOKKEEPER-1038: Fix findbugs warnings and upgrade to 3.0.4
- upgrade to findbugs 3.0.4
- fix DLS_DEAD_LOCAL_STORE At BookieInfoReader.java (introduce a constant)
- fix EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC At PerChannelBookieClient.java
(introduce a V3CompletionKey)
Author: eolivelli <eolive...@apache.org>
Reviewers: Sijie Guo <si...@apache.org>
Closes #131 from eolivelli/BOOKKEEPER-1038-findbugs
{noformat}
> Fix findbugs warnings and upgrade to 3.0.4
> ------------------------------------------
>
> Key: BOOKKEEPER-1038
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1038
> Project: Bookkeeper
> Issue Type: Task
> Components: build
> Affects Versions: 4.5.0
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Fix For: 4.5.0
>
>
> This findbugs errors are on master, they have to be fixed
> {code}
> INFO] --- findbugs-maven-plugin:3.0.3:check (default-cli) @ bookkeeper-server
> ---
> [INFO] BugInstance size is 2
> [INFO] Error size is 0
> [INFO] Total bugs: 2
> [INFO] Dead store to requested in
> org.apache.bookkeeper.client.BookieInfoReader.getReadWriteBookieInfo(Collection)
> [org.apache.bookkeeper.client.BookieInfoReader] At
> BookieInfoReader.java:[line 166] DLS_DEAD_LOCAL_STORE
> [INFO] org.apache.bookkeeper.proto.PerChannelBookieClient$V2CompletionKey
> overrides equals in PerChannelBookieClient$CompletionKey and may not be
> symmetric
> [org.apache.bookkeeper.proto.PerChannelBookieClient$V2CompletionKey] At
> PerChannelBookieClient.java:[lines 1720-1724]
> EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC
> [INFO]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
