[
https://issues.apache.org/jira/browse/BOOKKEEPER-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enrico Olivelli reopened BOOKKEEPER-925:
----------------------------------------
I think we should upgrade to findbugs 3.0.0, on my PC I get this error (maybe
because I use jdk8)
{code}
INFO] --- findbugs-maven-plugin:2.5.2:findbugs (default-cli) @
bookkeeper-stats-api ---
[INFO] Fork Value is true
[java] The following errors occurred during analysis:
[java] apr 29, 2016 2:50:04 PM edu.umd.cs.findbugs.TextUIBugReporter
reportAnalysisError
[java] GRAVE: Unable to get XClass for java/lang/StringBuilder
[java] java.lang.ArrayIndexOutOfBoundsException: 5747
[java] at org.objectweb.asm.ClassReader.readClass(Unknown Source)
[java] at org.objectweb.asm.ClassReader.accept(Unknown Source)
[java] at
edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
[java] at org.objectweb.asm.ClassReader.accept(Unknown Source)
[java] at
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:110)
[java] at
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:554)
[java] at
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:76)
[java] at
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
[java] at
edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:266)
[java] at edu.umd.cs.findbugs.ba.XFactory.getXClass(XFactory.java:652)
[java] at
edu.umd.cs.findbugs.ba.ch.Subtypes2.addInheritanceEdge(Subtypes2.java:1227)
[java] at
edu.umd.cs.findbugs.ba.ch.Subtypes2.addSupertypeEdges(Subtypes2.java:1200)
[java] at
edu.umd.cs.findbugs.ba.ch.Subtypes2.addClassAndGetClassVertex(Subtypes2.java:275)
[java] at
edu.umd.cs.findbugs.ba.ch.Subtypes2.addClass(Subtypes2.java:244)
[java] at
edu.umd.cs.findbugs.ba.AnalysisCacheToAnalysisContextAdapter.setAppClassList(AnalysisCacheToAnalysisContextAdapter.java:400)
[java] at
edu.umd.cs.findbugs.FindBugs2.setAppClassList(FindBugs2.java:982)
[java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:225)
[java] at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:391)
[java] at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1300)
[java] Unable to get XClass for java/lang/StringBuilder
[java] java.lang.ArrayIndexOutOfBoundsException: 5747
{code}
> Fix FindBugs discovered issues in master
> ----------------------------------------
>
> Key: BOOKKEEPER-925
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-925
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Fix For: 4.4.0
>
>
> After we have fixed unit tests in master, we are seeing FindBugs warnings:
> {noformat}
> [INFO] --- findbugs-maven-plugin:2.5.2:check (default-cli) @
> bookkeeper-server ---
> [INFO] BugInstance size is 6
> [INFO] Error size is 0
> [INFO] Total bugs: 6
> [INFO] Found reliance on default encoding in
> org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd.runCmd(CommandLine):
> new String(byte[])
> ["org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd"] At
> BookieShell.java:[lines 403-474]
> [INFO] Exception is caught when Exception is not thrown in
> org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector.gc(GarbageCollector$GarbageCleaner)
> ["org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector"] At
> ScanAndCompareGarbageCollector.java:[lines 64-227]
> [INFO] org.apache.bookkeeper.client.BookieWatcher.<static initializer>()
> invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead
> ["org.apache.bookkeeper.client.BookieWatcher"] At BookieWatcher.java:[lines
> 60-308]
> [INFO] org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager.LOCK_DATA
> should be package protected
> ["org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager"] At
> ZkLedgerUnderreplicationManager.java:[lines 76-664]
> [INFO] Synchronization performed on
> java.util.concurrent.ConcurrentLinkedQueue in
> org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler.writeRequested(ChannelHandlerContext,
> MessageEvent) ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler"]
> At AuthHandler.java:[lines 210-302]
> [INFO] Synchronization performed on
> java.util.concurrent.ConcurrentLinkedQueue in
> org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback.operationComplete(int,
> Void)
> ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback"]
> At AuthHandler.java:[lines 333-354]
> [INFO]
> ------------------------------------------------------------------------
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
