[
https://issues.apache.org/jira/browse/BOOKKEEPER-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262968#comment-15262968
]
ASF GitHub Bot commented on BOOKKEEPER-925:
-------------------------------------------
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/40
BOOKKEEPER-925: Fix FindBugs discovered issues in master
@sijie Fixed the other findbugs error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper bk-925
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit af1f86503ead8f62a999e1bb84e1b173057ee8f0
Author: Matteo Merli <[email protected]>
Date: 2016-04-28T20:53:00Z
BOOKKEEPER-925: Fix FindBugs discovered issues in master
----
> Fix FindBugs discovered issues in master
> ----------------------------------------
>
> Key: BOOKKEEPER-925
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-925
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Fix For: 4.4.0
>
>
> After we have fixed unit tests in master, we are seeing FindBugs warnings:
> {noformat}
> [INFO] --- findbugs-maven-plugin:2.5.2:check (default-cli) @
> bookkeeper-server ---
> [INFO] BugInstance size is 6
> [INFO] Error size is 0
> [INFO] Total bugs: 6
> [INFO] Found reliance on default encoding in
> org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd.runCmd(CommandLine):
> new String(byte[])
> ["org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd"] At
> BookieShell.java:[lines 403-474]
> [INFO] Exception is caught when Exception is not thrown in
> org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector.gc(GarbageCollector$GarbageCleaner)
> ["org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector"] At
> ScanAndCompareGarbageCollector.java:[lines 64-227]
> [INFO] org.apache.bookkeeper.client.BookieWatcher.<static initializer>()
> invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead
> ["org.apache.bookkeeper.client.BookieWatcher"] At BookieWatcher.java:[lines
> 60-308]
> [INFO] org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager.LOCK_DATA
> should be package protected
> ["org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager"] At
> ZkLedgerUnderreplicationManager.java:[lines 76-664]
> [INFO] Synchronization performed on
> java.util.concurrent.ConcurrentLinkedQueue in
> org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler.writeRequested(ChannelHandlerContext,
> MessageEvent) ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler"]
> At AuthHandler.java:[lines 210-302]
> [INFO] Synchronization performed on
> java.util.concurrent.ConcurrentLinkedQueue in
> org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback.operationComplete(int,
> Void)
> ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback"]
> At AuthHandler.java:[lines 333-354]
> [INFO]
> ------------------------------------------------------------------------
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
