The artifacts and signatures all look good, and I validated a couple of Python pipelines in a fresh install.
Assuming all the tests (including the Dataflow ones) pass (modulo the two mentioned above; seems a fair justification to not block on those) I'm +1 (binding) on this release. On Wed, Apr 26, 2023 at 12:39 PM Jack McCluskey via dev <dev@beam.apache.org> wrote: > There's also a good chance that newer test suites haven't been included in > mass_comment.py ( > https://github.com/apache/beam/blob/master/release/src/main/scripts/mass_comment.py) > and as a result they were not executed. > > On Wed, Apr 26, 2023 at 3:29 PM Jack McCluskey <jrmcclus...@google.com> > wrote: > >> The Dataflow CrossLanguageValidatesRunner GoUsingJava Tests have been >> broken for quite some time (https://github.com/apache/beam/issues/21645) >> and the Kafka issue is tied to a test timeout that John Casey has fixed but >> didn't get cherrypicked (just fell through the cracks while waiting on >> tests to pass, but conversations with them led to the conclusion that we >> would just get it into an RC2 if necessary since it's a matter of how the >> tests run not how the code under test functions.) >> >> The tests still marked "pending" passed but did not get updated on the >> GitHub side from when Jenkins was straining under load, I'm guessing those >> builds have since been deleted under our new retention policy to >> alleviate the OOM Jenkins issues. I will try to re-run those for the sake >> of having clear and obvious results. >> >> On Wed, Apr 26, 2023 at 3:23 PM Valentyn Tymofieiev <valen...@google.com> >> wrote: >> >>> Thanks, Jack! >>> >>> re [12]: >>> >>> I am seeing some test errors - have they been investigated? >>> Also, did all test suites run? I think I am not seeing output of some of >>> the suites, like >>> >>> Run Python Dataflow V2 ValidatesRunner >>> >>> >>> >>> On Wed, Apr 26, 2023 at 9:14 PM Jack McCluskey via dev < >>> dev@beam.apache.org> wrote: >>> >>>> Hi everyone, >>>> >>>> Please review and vote on the release candidate #3 for the version >>>> 1.2.3, as follows: >>>> [ ] +1, Approve the release >>>> [ ] -1, Do not approve the release (please provide specific comments) >>>> >>>> Reviewers are encouraged to test their own use cases with the release >>>> candidate, and vote +1 if no issues are found. >>>> >>>> The complete staging area is available for your review, which includes: >>>> * GitHub Release notes [1], >>>> * the official Apache source release to be deployed to dist.apache.org >>>> [2], which is signed with the key with fingerprint DF3CBA4F3F4199F4 [3], >>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>> * source code tag "v2.47.0-RC1" [5], >>>> * website pull request listing the release [6], the blog post [6], and >>>> publishing the API reference manual [7]. >>>> * Java artifacts were built with Gradle 7.5.1 and OpenJDK/Oracle JDK >>>> 8.0.322. >>>> * Python artifacts are deployed along with the source release to the >>>> dist.apache.org [2] and PyPI[8]. >>>> * Go artifacts and documentation are available at pkg.go.dev [9] >>>> * Validation sheet with a tab for 2.47.0 release to help with >>>> validation [10]. >>>> * Docker images published to Docker Hub [11]. >>>> * PR to run tests against release branch [12]. >>>> >>>> The vote will be open for at least 72 hours. It is adopted by majority >>>> approval, with at least 3 PMC affirmative votes. >>>> >>>> For guidelines on how to try the release in your projects, check out >>>> our blog post at /blog/validate-beam-release/. >>>> >>>> *Note: Dataflow containers for Java are still being finalized. I will >>>> follow up once that is completed; however, this should not block validation >>>> for other SDKs and runners. * >>>> >>>> Thanks, >>>> >>>> Jack McCluskey >>>> >>>> [1] https://github.com/apache/beam/milestone/10 >>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.47.0/ >>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>> [4] >>>> https://repository.apache.org/content/repositories/orgapachebeam-1309/ >>>> [5] https://github.com/apache/beam/tree/v2.47.0-RC1 >>>> [6] https://github.com/apache/beam/pull/26439 >>>> [7] https://github.com/apache/beam-site/pull/644 >>>> [8] https://pypi.org/project/apache-beam/2.47.0rc1/ >>>> [9] >>>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.47.0-RC1/go/pkg/beam >>>> [10] >>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=. >>>> .. >>>> [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>> [12] https://github.com/apache/beam/pull/26152 >>>> >>> >>> >>>> >>>> -- >>>> >>>> >>>> Jack McCluskey >>>> SWE - DataPLS PLAT/ Dataflow ML >>>> RDU >>>> jrmcclus...@google.com >>>> >>>> >>>>
