Oh great! Thank you guys! On Sat, Mar 5, 2022, 00:53 Ahmet Altay <al...@google.com> wrote:
> No worries. David's PR fixed it. Thank you for reporting! > > On Fri, Mar 4, 2022 at 1:49 PM Kirill Love <azert...@gmail.com> wrote: > >> Hey guys >> >> Sorry I haven't had the time to get it done. It's still on my todo list >> though! I will find the time this weekend to make the necessary changes. >> >> Sincerely >> >> >> Kirill Ism >> >> On Fri, Mar 4, 2022, 19:29 Ahmet Altay <al...@google.com> wrote: >> >>> Thank you! >>> >>> On Fri, Mar 4, 2022 at 10:18 AM David Cavazos <dcava...@google.com> >>> wrote: >>> >>>> Thanks! Sorry this got lost in my inbox. I opened a PR to update both >>>> points. >>>> >>>> https://github.com/apache/beam/pull/17018 >>>> >>>> On Fri, Mar 4, 2022 at 9:04 AM Ahmet Altay <al...@google.com> wrote: >>>> >>>>> Hi Kirill, have you had a chance to create a PR? It is ok if you did >>>>> not have time. >>>>> >>>>> @David Cavazos <dcava...@google.com> - Could you please fix the issue >>>>> Kirill reported if it is still open? >>>>> >>>>> On Wed, Feb 9, 2022 at 8:54 AM Ahmet Altay <al...@google.com> wrote: >>>>> >>>>>> Awesome :) And feel free to add me as the reviewer! >>>>>> >>>>>> On Wed, Feb 9, 2022 at 4:55 AM Kirill Love <azert...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> Dear Ahmet, David >>>>>>> >>>>>>> That’s a good suggestion! I’ll try to free up some time in the >>>>>>> weekend to create a PR for this. >>>>>>> >>>>>>> Sincerely >>>>>>> >>>>>>> >>>>>>> Kirill Ism >>>>>>> >>>>>>> On 9 Feb 2022, at 03:15, Ahmet Altay <al...@google.com> wrote: >>>>>>> >>>>>>> Thank you for the feedback Kirill. If you have time we will >>>>>>> happily accept your contribution in the form of a PR :) >>>>>>> >>>>>>> @David Cavazos <dcava...@google.com> - You are the author of this >>>>>>> page. Would you like to make the changes? >>>>>>> >>>>>>> On Tue, Feb 8, 2022 at 9:20 AM Kirill Love <azert...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Adapt documentation: >>>>>>>> >>>>>>>> >>>>>>>> https://beam.apache.org/documentation/transforms/python/elementwise/pardo/#example-1-pardo-with-a-simple-dofn >>>>>>>> >>>>>>>> ## Can be removed >>>>>>>> >>>>>>>> [BEAM-7885] <https://issues.apache.org/jira/browse/BEAM-7885> >>>>>>>> DoFn.setup() doesn’t run for streaming jobs running in the >>>>>>>> DirectRunner. >>>>>>>> >>>>>>>> >>>>>>>> Issue has been resolved. >>>>>>>> >>>>>>>> >>>>>>>> ## Can be changed >>>>>>>> >>>>>>>> self.window = beam.window.GlobalWindow() >>>>>>>> >>>>>>>> >>>>>>>> New path is: >>>>>>>> >>>>>>>> beam.transforms.window.GlobalWindow() >>>>>>>> >>>>>>>> >>>>>>>> Sincerely >>>>>>>> >>>>>>>> >>>>>>>> Kirill Ism >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>
