+1 Ran the verification scripts.
Caveats: - I input a GCS bucket that did not exist, expecting it to be created, so the Dataflow tests failed. - I also skipped the Python tests that asked to write to GitHub. - You also have not built, staged, & signed the Python wheels. It is a bit hidden in the release guide under the "run all steps manually" section (even though manual is the only way to do it). Here: https://beam.apache.org/contribute/release-guide/#stage-python-binaries-on-distapacheorg. It requires inputting your credentials to Travis-CI, so do what you need to do to feel OK about that (I changed my credentials to a UUID and changed back, trusting Travis not to capture my account instantly). It may be possible to quickly change the target for the multibuild upload to another destination where you can create a limited key for it to use. Kenn On Mon, Apr 15, 2019 at 3:51 PM Andrew Pilloud <apill...@google.com> wrote: > Hi everyone, > > Please review and vote on the release candidate #4 for the version 2.12.0, > as follows: > > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * JIRA release notes [1], > * the official Apache source release to be deployed to dist.apache.org > [2], which is signed with the key with fingerprint 9E7CEC0661EFD610B6 > 32C610AE8FE17F9F8AE3D4 [3], > * all artifacts to be deployed to the Maven Central Repository [4], > * source code tag "v2.12.0-RC4" [5], > * website pull request listing the release [6], publishing the API > reference manual [7], and the blog post [8]. > * Java artifacts were built with Gradle/5.2.1 and OpenJDK/Oracle JDK > 1.8.0_181. > * Python artifacts are deployed along with the source release to the > dist.apache.org [2]. > * Validation sheet with a tab for 2.12.0 release to help with validation > [9]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Andrew > > 1] > https://jira.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12344944 > [2] https://dist.apache.org/repos/dist/dev/beam/2.12.0/ > [3] https://dist.apache.org/repos/dist/release/beam/KEYS > [4] https://repository.apache.org/content/repositories/orgapachebeam-1068/ > [5] https://github.com/apache/beam/tree/v2.12.0-RC4 > [6] https://github.com/apache/beam/pull/8215 > [7] https://github.com/apache/beam-site/pull/588 > [8] https://github.com/apache/beam/pull/8314 > [9] > https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1007316984 >
