Decided to go with https://github.com/apache/beam/pull/4360 to start. It still relies on hamcrest - which should be dropped at some point for JUnit 5 - but it is not a blocker to use JUnit 5 and the asserts can be done with assertTrue(BooleanSupplier) or any other JUnit 5 utility.
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> 2018-01-06 14:54 GMT+01:00 Jean-Baptiste Onofré <j...@nanthrax.net>: > PAssert & TestPipeline are the first targets for sure. We have some extend > of TestPipeline (for instance in the Spark runner for streaming part). But > it should be transparent. > > Regards > JB > > On 01/06/2018 09:09 AM, Romain Manni-Bucau wrote: > >> PAssert is the next one I'd like to tackle once i managed to run the test >> (need to fix the runner setup in my branch). Otherwise logic seems >> extractable not too badly so I'm very optimistic. >> >> If you have some utilities you want I have a look just dump it here, I >> will try to check beginning of next week. >> >> Ps: is it ok to do 1 pr for the pipeline and one for passert? I prefer >> small merges for now if ok. >> >> Le 6 janv. 2018 01:24, "Lukasz Cwik" <lc...@google.com <mailto: >> lc...@google.com>> a écrit : >> >> That sounds interesting. >> Will there be compatibility challenges with how much changed between >> JUnit 4 >> and 5 since I believe we have a lot of testing utilities in our test >> jars >> which some users do rely on. >> >> On Fri, Jan 5, 2018 at 9:08 AM, Romain Manni-Bucau < >> rmannibu...@gmail.com >> <mailto:rmannibu...@gmail.com>> wrote: >> >> FYI, started to code a bit in >> https://github.com/rmannibucau/incubator-beam/tree/fb/BEAM- >> 3415_junit-5-integration >> <https://github.com/rmannibucau/incubator-beam/tree/fb/BEAM- >> 3415_junit-5-integration> >> >> The surefire setup is not yet correct but it gives some idea of >> where it >> goes if you want to have a look. >> >> Will try to finish it next week >> >> Have a good week-end! >> >> >> Romain Manni-Bucau >> @rmannibucau <https://twitter.com/rmannibucau> | Blog >> <https://rmannibucau.metawerx.net/> | Old Blog >> <http://rmannibucau.wordpress.com> | Github >> <https://github.com/rmannibucau> | LinkedIn >> <https://www.linkedin.com/in/rmannibucau> >> >> 2018-01-05 15:45 GMT+01:00 Jean-Baptiste Onofré <j...@nanthrax.net >> <mailto:j...@nanthrax.net>>: >> >> It sounds good, thanks. Let me add as reviewer on the PR. >> >> Thanks ! >> Regards >> JB >> >> On 01/05/2018 03:41 PM, Romain Manni-Bucau wrote: >> >> created https://issues.apache.org/jira/browse/BEAM-3415 >> <https://issues.apache.org/jira/browse/BEAM-3415> for >> reference >> >> >> Romain Manni-Bucau >> @rmannibucau <https://twitter.com/rmannibucau >> <https://twitter.com/rmannibucau>> | Blog >> <https://rmannibucau.metawerx.net/ >> <https://rmannibucau.metawerx.net/>> | Old Blog >> <http://rmannibucau.wordpress.com >> <http://rmannibucau.wordpress.com>> | Github >> <https://github.com/rmannibucau >> <https://github.com/rmannibucau>> | LinkedIn >> <https://www.linkedin.com/in/rmannibucau >> <https://www.linkedin.com/in/rmannibucau>> >> >> 2018-01-05 11:43 GMT+01:00 Jean-Baptiste Onofré < >> j...@nanthrax.net >> <mailto:j...@nanthrax.net> <mailto:j...@nanthrax.net >> >> <mailto:j...@nanthrax.net>>>: >> >> Hi, >> >> not yet planned. >> >> But interesting for sure. >> >> Regards >> JB >> >> On 01/05/2018 10:45 AM, Romain Manni-Bucau wrote: >> >> Hi guys, >> >> Any plan to work on a JUnit 5 test pipeline? >> >> I can surely give some help if needed but would >> be nice >> to support it soon. >> >> Romain Manni-Bucau >> @rmannibucau <https://twitter.com/rmannibucau >> <https://twitter.com/rmannibucau> >> <https://twitter.com/rmannibucau >> <https://twitter.com/rmannibucau>>> | Blog >> <https://rmannibucau.metawerx.net/ >> <https://rmannibucau.metawerx.net/> >> <https://rmannibucau.metawerx.net/ >> <https://rmannibucau.metawerx.net/>>> | Old Blog >> <http://rmannibucau.wordpress.com >> <http://rmannibucau.wordpress.com> >> <http://rmannibucau.wordpress.com >> <http://rmannibucau.wordpress.com>>> | >> Github <https://github.com/rmannibucau >> <https://github.com/rmannibucau> >> <https://github.com/rmannibucau >> <https://github.com/rmannibucau>>> | LinkedIn >> <https://www.linkedin.com/in/rmannibucau >> <https://www.linkedin.com/in/rmannibucau> >> <https://www.linkedin.com/in/rmannibucau >> <https://www.linkedin.com/in/rmannibucau>>> >> >> >> -- Jean-Baptiste Onofré >> jbono...@apache.org <mailto:jbono...@apache.org> >> <mailto:jbono...@apache.org <mailto:jbono...@apache.org>> >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> >> >> >> -- Jean-Baptiste Onofré >> jbono...@apache.org <mailto:jbono...@apache.org> >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> >> >> >> > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com >
