Hello Calvin, Thanks a lot for this feedback. I will add the DISCLAIMER and release a new candidate version.
Regarding the NOTICE file, I think there’s some flexibility in how projects interpret and include information in it. Some projects mention only what’s required, while others, such as Hadoop, seem more inclined to include as much information as possible. Personally, I’d prefer to include only what’s necessary, as it makes it easier to keep the information up to date (the hard part). From what I understand from "Section 4. Redistribution" of the license: a) Ok. The Apache license is included. b) Ok. The derivative works in our sources retain the license, copyright, and are mentioned in our NOTICE file. c) Ok. The copyright of the derivative works included in our sources is retained. A list of all our dependencies and their respective LICENSE files is appended to the LICENSE file in the binary distribution. d) This looks fine to me. From what I understand, this mainly applies to the work derived from Apache Baremaps (e.g., the binary distribution) which must retain our NOTICE file. If this analysis is incorrect, I’d really appreciate a pull request that directly addresses the issues or a pair programming session with a mentor where we can take concrete actions. Best regards, Bertil ———— 4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions: a) You must give any other recipients of the Work or Derivative Works a copy of this License; and b) You must cause any modified files to carry prominent notices stating that You changed the files; and c) You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and d) If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. > On 12 Nov 2024, at 08:24, Calvin Kirs <k...@apache.org> wrote: > > -1 binding > > I checked: > > Source Package > > - The DISCLAIMER file is missing (we need to include this file during > incubation). > - The NOTICE and LICENSE files look good. > > Binary Package > > - The DISCLAIMER file is missing. > - The LICENSE file looks fine, but you haven’t included LICENSE files for > other dependencies [1], such as Hadoop [2]. > - The NOTICE file should follow Section 4 of the Apache License 2.0 (AL2) > [3]. (If dependencies use AL2 and have a NOTICE file, AL2 generally > requires including them. To be honest, I’ve only seen this requirement with > AL2 .) For example [4]. > > > > [1]https://www.apache.org/legal/release-policy.html#license-file > [2]https://github.com/apache/hadoop/tree/trunk/licenses-binary > [3]https://www.apache.org/licenses/LICENSE-2.0.html > [4]https://github.com/apache/hadoop/blob/trunk/NOTICE-binary > > > > On Mon, Nov 11, 2024 at 3:33 PM Leo <leocser...@gmail.com> wrote: > >> +1 >> >> Compiled on macOS, java 21 + checked sources >> >>> On 9 Nov 2024, at 15:48, Bertil Chapuis <bchap...@gmail.com> wrote: >>> >>> Hello Everyone, >>> >>> I have created a build for Apache Baremaps (incubating) 0.8.1, release >> candidate 1. This release comes with exciting changes, including support >> for geoparquet, rasters, contours, and hillshade (more highlights in the >> release notes). Additionally, I removed the DISCLAIMER-WIP, as we addressed >> all the known issues related to licensing. Thanks to everyone who has >> contributed to this release! >>> >>> You can read the release notes here: >>> https://github.com/apache/incubator-baremaps/releases/tag/v0.8.1-rc1 >>> >>> The commit to be voted upon: >>> https://github.com/apache/incubator-baremaps/tree/v0.8.1-rc1 >>> >>> Its tag is v0.8.1-rc1 and its hash is >> a278ee95120965aa39eeaf848484abff3f3950f6. >>> >>> The artifacts to be voted on are located here: >>> https://dist.apache.org/repos/dist/dev/incubator/baremaps/0.8.1-rc1/ >>> >>> The hashes of the artifacts are as follows: >>> >> 72f9fce28d874a1965cefaad248a54b7984c833b110264b30210a25579e695933af20386d00da3c9e2c446709e87b33d4935658e9ed7ab7b5e79b5cf1ec1c8d7 >> ./apache-baremaps-0.8.1-rc1-incubating-src.tar.gz >>> >> 4ae01426272b30e2df2fc5cad6a9efcad1d6c2dc26fc05befce1d9503e751737aecb0b4015cd5c6e990716530c3272c365e859438da4813acc5b9748e2c12c31 >> ./apache-baremaps-0.8.1-rc1-incubating-bin.tar.gz >>> >>> Release candidate artifacts are signed automatically with the key >> (C81AC42AF2A7CACDF4C8A4F6936E280DF16599CB) created by the INFRA team: >>> https://downloads.apache.org/incubator/baremaps/KEYS >>> >>> The README file for the src distribution contains instructions for >> building and testing the release. >>> >>> Please vote on releasing this package as Apache Baremaps 0.8.1. >>> >>> The vote is open for 72 hours starting on Monday. It passes if a >> majority of at least three +1 PMC votes are cast. >>> [ ] +1 Release this package as Apache Baremaps 0.8.1 >>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>> [ ] -1 Do not release this package because... >>> >>> Here is my vote: >>> +1 (non-binding): I built from source; executed the binary distribution; >> checked the checksums; checked the signatures. >>> >>> Best regards, >>> >>> Bertil >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@baremaps.apache.org >>> For additional commands, e-mail: dev-h...@baremaps.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@baremaps.apache.org >> For additional commands, e-mail: dev-h...@baremaps.apache.org >> >> > > -- > Best wishes！ > CalvinKirs --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@baremaps.apache.org For additional commands, e-mail: dev-h...@baremaps.apache.org
