travisdowns opened a new pull request, #3906: URL: https://github.com/apache/avro/pull/3906
## What is the purpose of the change `lang/c++/impl/Node.cc` uses `std::vector<std::string>` directly (the `raw` member of `Name` and the return type of `Name::aliases()`) but does not include `<vector>`. It compiles today only because `avro/Node.hh` happens to include `<vector>` transitively. That transitive dependency is fragile: a consumer building the C++ SDK against a header layout or standard library where `Node.hh` does not pull in `<vector>` fails to compile this translation unit. We hit exactly that downstream and are currently carrying it as a local patch. This adds the direct include so the file is self-contained. Same class of change as #3808 (`MINOR: [C++] Add missing header <type_traits>`), hence no JIRA issue. For what it is worth, `lang/c++/impl/Stream.cc` had the equivalent problem and is already fixed on `main`, so this looks like the remaining instance in that pair. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
