Hi, +1 (binding)
Just had a cursory look at the code changes listed. Looks good to me! Kind regards, Oscar On Mon, 23 Jun 2025 at 07:17, Martin Grigorov <mgrigo...@apache.org> wrote: > We need one more binding vote > > On Mon, Jun 16, 2025 at 5:24 PM Fokko Driesprong <fo...@apache.org> wrote: > > > +1 (binding) > > > > Op ma 16 jun 2025 om 15:35 schreef Jean-Baptiste Onofré <j...@nanthrax.net > >: > > > > > +1 (non binding) > > > > > > Regards > > > JB > > > > > > On Fri, Jun 6, 2025 at 9:39 AM Martin Grigorov <mgrigo...@apache.org> > > > wrote: > > > > > > > > Hi everyone, > > > > > > > > I'd like to propose the following RC0 to be released as the official > > > > Apache Avro-rs 0.19.0 release. > > > > > > > > The commit id is > > > > > > > > > > https://github.com/apache/avro-rs/commit/37ff2526e631669ed137c5099660cc2984eda32e > > > > * This corresponds to the tag: rel/release-0.19.0-rc0 > > > > * > > > > https://github.com/apache/avro-rs/releases/tag/rel%2Frelease-0.19.0-rc0 > > > > > > > > The release tarball, signature, and checksums are here (revision > > r77409) > > > > * https://dist.apache.org/repos/dist/dev/avro/avro-rs/0.19.0/ > > > > > > > > You can find the KEYS file here: > > > > * https://dist.apache.org/repos/dist/release/avro/KEYS > > > > > > > > This release includes: > > > > * feat: Add settings for Codec::Deflate by @martin-g in > > > > https://github.com/apache/avro-rs/pull/174 > > > > * doc: Update Rustdoc of ser_schema.rs to match with the current > > struct > > > > names by @thynson in https://github.com/apache/avro-rs/pull/176 > > > > * ci: Fix CI badge in readme by @erikbrinkman in > > > > https://github.com/apache/avro-rs/pull/183 > > > > * fix: #181 - Do not error if there is nothing to read by @martin-g > in > > > > https://github.com/apache/avro-rs/pull/182 > > > > * feat: Support different header types by @masongup-mdsol in > > > > https://github.com/apache/avro-rs/pull/190 > > > > * feat: Expose the capability to do headerless avro encoding with > serde > > > by > > > > @allenbenz in https://github.com/apache/avro-rs/pull/193 > > > > * perf: Reduce the size of Error from 256 bytes to 88 bytes by > > > @Kriskras99 > > > > in https://github.com/apache/avro-rs/pull/194 > > > > * feat: Accept more inputs for `Schema::parse_(str_with)_list` by > > > > @Kriskras99 in https://github.com/apache/avro-rs/pull/195 > > > > * chore: Fix a bunch of new Clippy lints by @Kriskras99 in > > > > https://github.com/apache/avro-rs/pull/196 > > > > * feat: Add `get_ref` and `get_mut` methods to `Writer` by > @Kriskras99 > > in > > > > https://github.com/apache/avro-rs/pull/201 > > > > * fix: flush Writer on drop by @Kriskras99 in > > > > https://github.com/apache/avro-rs/pull/199 > > > > > > > > and several dependency updates by Dependabot > > > > > > > > The easiest way to test the release is: > > > > * mkdir 0.19.0 && cd 0.19.0 > > > > * wget -q > > > > > > > > > > https://dist.apache.org/repos/dist/dev/avro/avro-rs/0.19.0/apache-avro-rs-0.19.0-RC0.tgz > > > > * tar xvf apache-avro-rs-0.19.0-RC0.tgz > > > > * cargo fmt --check && cargo test > > > > * (optional) Update your project Cargo.toml to use `apache_avro = { > > path > > > = > > > > "/path/to/0.19.0/avro" } and test your application > > > > > > > > Please download, verify, and test. This vote will remain open for at > > > > least 72 hours. > > > > > > > > [ ] +1 Release this as Apache Avro-rs 0.19.0 > > > > [ ] 0 > > > > [ ] -1 Do not release this because... > > > > > > > > Regards, > > > > Martin > > > > > > -- ✉️ Oscar Westra van Holthe - Kind <os...@westravanholthe.nl>
