wgtmac opened a new pull request, #3344: URL: https://github.com/apache/avro/pull/3344
## What is the purpose of the change This PR takes a different approach than https://github.com/apache/avro/pull/3308, https://github.com/apache/avro/pull/3069, https://github.com/apache/avro/pull/3064 and https://github.com/apache/avro/pull/3266 to fix the non-string custom attributes. It extends the `CustomAttributes::addAttribute(const std::string &name, const std::string &value)` with a third parameter `bool addQuotes` with default value set to `true` to support adding non-string values explicitly and keep backward compatibility. ## Verifying this change - Make sure that all existing test cases are passed so backward compatibility is preserved. - Added new test case to verify that both `json->schema->json` and `schema->json->schema` round trips have preserved non-string attributes correctly. ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? added comment to explain the behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
