wgtmac opened a new pull request, #3332:
URL: https://github.com/apache/avro/pull/3332
   ## What is the purpose of the change
   
   My previous work in https://github.com/apache/avro/pull/3325 introduces a 
new `Node::getCustomAttributes` API to return (consolidated) custom attributes. 
However, this implementation is wrong because a `Node` instance holds a 
separate CustomAttribute for each leaf node. This patch fixes it by replacing 
`Node::getCustomAttributes` with two new functions `Node::customAttributes` and 
`Node::customAttributesAt` to match other methods from Node for name, default 
value, etc.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Added test cases to SchemaTests to verify that custom attributes from 
different node types are preserved and parsed correctly.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to