mkeskells opened a new pull request, #3307: URL: https://github.com/apache/avro/pull/3307
## What is the purpose of the change - Fix the class cast exceptions noted in the ticket (when using logical types) - Fix other paths that can return `PrimitiveArray` when it would not be appropriate - Tightness the constraints for the return value, so if a `GenericContainer` is returned the schema must match the supplied schema appropriate means that - If the suppled value could act as a container for the values that will be added, then clear its values, and reuse - If it is a `GenericContainer` and thus has a schema, then the schema is the same If we can't reuse the supplied value, then generate an appropriate collection, using the optimised values where we can Updated the documentation, and added tests ## Verifying this change This change added tests and can be verified as follows: - Added unit tests to ensure that appropriate values are returned (as described above) ## Documentation - Does this pull request introduce a new feature? (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
