Thank you all! With 3 binding +1s and 4 non-binding +1s the vote passed!
I will start working on this task soon! Martin On Fri, Aug 30, 2024 at 5:06 AM Xuanwo <xua...@apache.org> wrote: > Maybe we can move forward? > > On Tue, Aug 27, 2024, at 15:20, Oscar Westra van Holthe - Kind wrote: > > +1 from me as well > > -- > > Oscar Westra van Holthe - Kind <os...@westravanholthe.nl> > > > > Op di 27 aug. 2024 08:40 schreef Renjie Liu <liurenjie2...@gmail.com>: > > > >> Thanks for bringing this up! > >> > >> +1 from my side. > >> > >> On Sat, Aug 24, 2024 at 11:46 AM xxchan <xxchan...@gmail.com> wrote: > >> > >> > +1 (non-binding). Thanks for bringing this up! > >> > > >> > BTW, another minor benefit to share: Previously if we use avro-rust > as a > >> > git dependency, Cargo will pull all submodules (docsy, then > >> Font-Awesome), > >> > which is a lot! (<https://github.com/rust-lang/cargo/issues/4247>) > >> Moving > >> > the Rust SDK to its own repo can also solve this pain point. > >> > > >> > On Sat, Aug 24, 2024 at 3:38 AM Fokko Driesprong <fo...@apache.org> > >> wrote: > >> > > >> > > Hey all, > >> > > > >> > > 1. Does the move to GitHub issues also include history? If not, how > >> will > >> > > we do > >> > > > the transition? And if yes, how will we ensure all issues will be > >> > > migrated > >> > > > somewhere? > >> > > > >> > > > >> > > Parquet recently migrated to Github, and an example can be found > here > >> > > <https://github.com/apache/parquet-java/issues/2854>. I believe it > is > >> > nice > >> > > to have everything in one place. I can reach out to Rok who did > this at > >> > > Parquet, if there is a majority for migrating from Jira to GitHub. > >> > > > >> > > > 2. Can we group all Avro repositories? Maybe using a GitHub > project? > >> > As I > >> > > > > understand, there is no equivalent of GitLab groups in GitHub > >> > (though I > >> > > > > hope I'm wrong > >> > > > >> > > > >> > > No such thing in GitHub. The only thing we can do is to use “avro-“ > as > >> > > > prefix. > >> > > > >> > > > >> > > That's actually a hard requirement ;) > >> > > > >> > > Kind regards, > >> > > Fokko > >> > > > >> > > > >> > > > >> > > > >> > > Op vr 23 aug 2024 om 20:57 schreef Xuanwo <xua...@apache.org>: > >> > > > >> > > > > >> > > > > 1. Does the move to GitHub issues also include history? If not, > how > >> > > will > >> > > > we > >> > > > > do the transition? And if yes, how will we ensure all issues > will > >> be > >> > > > > migrated somewhere? > >> > > > > >> > > > I believe we can migrate open issues to GitHub only and left old > >> issue > >> > > > there as before. I remembered that some projects have done similar > >> > > things. > >> > > > I will try to figure out how to implement. > >> > > > > >> > > > > 2. Can we group all Avro repositories? Maybe using a GitHub > >> project? > >> > > As I > >> > > > > understand, there is no equivalent of GitLab groups in GitHub > >> > (though I > >> > > > > hope I'm wrong > >> > > > > >> > > > No such thing in GitHub. The only thing we can do is to use > “avro-“ > >> as > >> > > > prefix. > >> > > > > >> > > > > >> > > > On Sat, Aug 24, 2024, at 01:37, Oscar Westra van Holthe - Kind > wrote: > >> > > > > Hi everyone, > >> > > > > > >> > > > > There's two thing's I like about the proposals: > >> > > > > - using the Rust SDK as a trailblazer > >> > > > > - migrating to github issues > >> > > > > > >> > > > > Before we go ahead though, I'd like us to answer a few > questions: > >> > > > > > >> > > > > 1. Does the move to GitHub issues also include history? If not, > how > >> > > will > >> > > > we > >> > > > > do the transition? And if yes, how will we ensure all issues > will > >> be > >> > > > > migrated somewhere? > >> > > > > > >> > > > > 2. Can we group all Avro repositories? Maybe using a GitHub > >> project? > >> > > As I > >> > > > > understand, there is no equivalent of GitLab groups in GitHub > >> > (though I > >> > > > > hope I'm wrong). > >> > > > > > >> > > > > > >> > > > > Kind regards, > >> > > > > > >> > > > > Oscar > >> > > > > > >> > > > > > >> > > > > > >> > > > > On Fri, Aug 23, 2024 at 3:28 PM Xuanwo <xua...@apache.org> > wrote: > >> > > > >> > >> > > > >> > Thank you for bringing this up. > >> > > > >> > > >> > > > >> > I fully support this. > >> > > > >> > > >> > > > >> > Here is my non-binding +1 vote. > >> > > > >> > > >> > > > >> > By the way, as a consequence of this split, will we > transition > >> to > >> > > > gitHub > >> > > > >> > issues and leave Jira simultaneously? > >> > > > >> > > >> > > > >> > >> > > > >> +1 to use Github Issues instead of Jira ! > >> > > > >> > >> > > > >> > >> > > > >> > > >> > > > >> > On Fri, Aug 23, 2024, at 20:18, Fokko Driesprong wrote: > >> > > > >> > > Thanks Martin for bringing this up, and I agree that this > is > >> the > >> > > > best > >> > > > >> > > solution when we want to support releases per language. > >> > > > >> > > > >> > > > >> > > +1 from my side. > >> > > > >> > > > >> > > > >> > > I would suggest doing Rust first, and based on the > experience > >> > see > >> > > > how > >> > > > >> we > >> > > > >> > > can move the other languages as well. > >> > > > >> > > > >> > > > >> > > Kind regards, > >> > > > >> > > Fokko > >> > > > >> > > > >> > > > >> > > Op vr 23 aug 2024 om 13:58 schreef Martin Grigorov < > >> > > > >> mgrigo...@apache.org > >> > > > >> > >: > >> > > > >> > > > >> > > > >> > >> +1 from me > >> > > > >> > >> > >> > > > >> > >> On Fri, Aug 23, 2024 at 2:57 PM Martin Grigorov < > >> > > > mgrigo...@apache.org > >> > > > >> > > >> > > > >> > >> wrote: > >> > > > >> > >> > >> > > > >> > >> > Hello, > >> > > > >> > >> > > >> > > > >> > >> > At > >> > > > https://lists.apache.org/thread/s074tydhytt8qtzxyj2vs8g5frq4rm3v > >> > > > >> > >> Fokko > >> > > > >> > >> > suggested extracting the SDKs into their own Git > >> > repositories. > >> > > > >> > >> > I'd like to formally start a vote for doing this for the > >> Rust > >> > > > SDK! > >> > > > >> > >> > > >> > > > >> > >> > The main benefit of doing this is to have its own > lifecycle > >> > and > >> > > > >> > >> versioning. > >> > > > >> > >> > Currently the development version of the Rust SDK is > 0.18.0 > >> > > while > >> > > > >> all > >> > > > >> > >> > other modules use 1.13.0-SNAPSHOT. > >> > > > >> > >> > > >> > > > >> > >> > The new repository would be apache/avro-rust ! It will > be > >> > > created > >> > > > >> via > >> > > > >> > the > >> > > > >> > >> > ASF self-service tools. > >> > > > >> > >> > > >> > > > >> > >> > It will preserve the Git history by using the following > >> > > commands: > >> > > > >> > >> > - git subtree split --prefix=lang/rust -b > avro-rust-branch > >> > > > >> > >> > - git push g...@github.com:apache/avro-rust.git > >> > > > >> avro-rust-branch:main > >> > > > >> > >> > AFAIU this won't delete the lang/rust/ folder from the > main > >> > > repo. > >> > > > >> The > >> > > > >> > >> Rust > >> > > > >> > >> > files and folders will be deleted once we make sure that > >> > > > everything > >> > > > >> > is as > >> > > > >> > >> > we want it in the new repository! > >> > > > >> > >> > > >> > > > >> > >> > Then the Rust specific Github Actions workflows would be > >> > moved > >> > > > over > >> > > > >> to > >> > > > >> > >> the > >> > > > >> > >> > new repository (probably without their Git history > since it > >> > is > >> > > > not > >> > > > >> > really > >> > > > >> > >> > important). They will be updated to checkout the main > repo > >> to > >> > > > make > >> > > > >> > use of > >> > > > >> > >> > the shared/ folder for the common and interop tests. > >> > > > >> > >> > > >> > > > >> > >> > Maybe a next step could be to invite > >> > > > >> > >> > https://github.com/lerouxrgd/rsgen-avro as a > member/sub- > >> > crate > >> > > > if > >> > > > >> the > >> > > > >> > >> > author is interested ! > >> > > > >> > >> > Some discussion has happened at > >> > > > >> > >> > https://github.com/lerouxrgd/rsgen-avro/pull/56 > >> > > > >> > >> > > >> > > > >> > >> > Regards, > >> > > > >> > >> > Martin > >> > > > >> > >> > > >> > > > >> > >> > >> > > > >> > > >> > > > >> > -- > >> > > > >> > Xuanwo > >> > > > >> > > >> > > > >> > https://xuanwo.io/ > >> > > > >> > > >> > > > >> > >> > > > > -- > >> > > > > Oscar Westra van Holthe - Kind <opw...@apache.org> > >> > > > > >> > > > -- > >> > > > Xuanwo > >> > > > > >> > > > https://xuanwo.io/ > >> > > > > >> > > > >> > > >> > > -- > Xuanwo > > https://xuanwo.io/ >
