Hi, On Mon, Aug 19, 2024 at 2:51 PM Katrin Skoglund <katrin.skogl...@avanza.se.invalid> wrote:
> Hey folks, > > I’m wondering about this old Jira and PR from 2017 ( > https://issues.apache.org/jira/browse/AVRO-2078). It’s a bit scary to > work with decimal types in Avro from Java since changes in precision and > scale are not considered incompatible but will royally mess up the data if > introduced. We have implemented our own validation for this and I was > considering adding that as a PR when I found this one. > > The Avro spec says “For the purposes of schema resolution, two schemas > that are decimal logical types match if their scales and precisions match”, > so that’s pretty clear IMO. > > My question is basically: > Is there a chance of getting this validation merged? If not as-is, then > maybe modified in some way (like making logical types validation > configurable). > I am not very familiar with the Java SDK, so I cannot comment on the technical solution but the PR has 5 files with merge conflicts, so it cannot be merged "as-is" for sure. Someone will have to rebase it to main branch! Martin > > I’m happy to help with the PR or create a new one if needed. > > Best, > Katrin >
