Hello everyone! It took me a while to get this building on my system. I definitely couldn't get it to work using the docker-test target, but I don't think that's a blocker either.
I can now build the source we are releasing into the artifacts, by using the following procedure: * Starting with a clean ~/.m2/repository without any prior compiled components. * Do a `mvn install -DskipTests` at the top level * Modify `lang/py/build.sh` to add `--recreate` to every tox call. * Run the docker with `DOCKER_RUN_XTRA_ARGS="--ulimit nofile=4096" ./build.sh docker` * In the docker, do a `./build.sh clean test` :D I have confidence that it worked straight away on your machines! I suspect one day when we can do the release builds automatically with the up-and-coming ASF "artifact platform" this fussiness will all be a distant memory. I've checked the Java artifacts against some simple existing code -- I didn't have enough time to do other SDKs this time around but I don't want to block this release. Thanks so much for doing this! +1 from me Ryan On Thu, Aug 1, 2024 at 10:25 AM Fokko Driesprong <fo...@apache.org> wrote: > > Hey Ryan, > > Thanks for checking out the release, and spotting the errors. > > - Sorry about the RC0 situation, for some reason this feels more natural > to me :) I've fixed the tag: > https://github.com/apache/avro/releases/tag/release-1.12.0-rc1 > - I agree that it is confusing having two KEYS files. I've dropped the > one in dev and added my key to the release ones. > > Let me know if you run into anything else. > > Kind regards, > Fokko > > Op wo 31 jul 2024 om 14:34 schreef Jean-Baptiste Onofré <j...@nanthrax.net>: > > > Hi Ryan > > > > Thanks for the update! > > > > Please let me know if I can help in any way! > > > > Regards > > JB > > > > On Wed, Jul 31, 2024 at 9:53 AM Ryan Skraba <r...@skraba.com> wrote: > > > > > > Quick update, when building last night, I ran into the bug AVRO-3454 > > > -- again this doesn't block this release, it just affects building the > > > source using docker on my OS (Fedora). I made the modification > > > suggested in the JIRA and I'm giving it another go right now. > > > > > > All my best, Ryan > > > > > > On Tue, Jul 30, 2024 at 8:25 PM Ryan Skraba <r...@skraba.com> wrote: > > > > > > > > Hello! Thanks so much for getting this release out, as well as > > > > updating the "How to release" guide! > > > > > > > > There's a couple of very minor issues that should be addressed for the > > > > release announcement and DO NOT block this release! > > > > > > > > - We typically start our releases at rc1, but this is labeled rc0 in > > > > svn and the github tag. The github tag should be fixed! > > > > - The github commit in this voting thread corresponds to 1.11.3, the > > > > correct commit ID 8c27801dc8d42ccc00997f25c0b8f45f8d4a233e > > > > - The signing key corresponds to Fokko's key at > > > > https://whimsy.apache.org/roster/committer/fokko, which isn't in the > > > > https://dist.apache.org/repos/dist/dev/avro/KEYS. This might have > > > > been updated in the release KEYS file? Maybe we should just delete > > > > the one in dev, I don't see the point in having two! > > > > > > > > I'm currently building the release from the SVN source from scratch > > > > (after deleting my docker build cache), I'll update with a vote soon! > > > > > > > > Thanks again! Ryan > > > > > > > > > > > > > > > > On Tue, Jul 30, 2024 at 8:11 PM Oscar Westra van Holthe - Kind > > > > <os...@westravanholthe.nl> wrote: > > > > > > > > > > Sorry about that, I misunderstood the docs I think. > > > > > > > > > > -- > > > > > Oscar Westra van Holthe - Kind <os...@westravanholthe.nl> > > > > > > > > > > Op di 30 jul. 2024 19:48 schreef Jean-Baptiste Onofré < > > j...@nanthrax.net>: > > > > > > > > > > > Hi Oscar, > > > > > > > > > > > > According to the record, you are committer, not PMC member, so your > > > > > > vote is non binding. > > > > > > > > > > > > We still need one additional binding vote. > > > > > > > > > > > > Thanks ! > > > > > > Regards > > > > > > JB > > > > > > > > > > > > On Tue, Jul 30, 2024 at 11:53 AM Oscar Westra van Holthe - Kind > > > > > > <os...@westravanholthe.nl> wrote: > > > > > > > > > > > > > > +1 (binding) to release 1.12.0 > > > > > > > > > > > > > > - Can build from source distribution > > > > > > > - Tested with some other projects (avro-conversions, some company > > > > > > projects, …) > > > > > > > > > > > > > > > > > > > > > Kind regards, > > > > > > > Oscar > > > > > > > > > > > > > > -- > > > > > > > Oscar Westra van Holthe - Kind <os...@westravanholthe.nl> > > > > > > > > > > > > > > > On 26 Jul 2024, at 16:56, Jean-Baptiste Onofré < > > j...@nanthrax.net> > > > > > > wrote: > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > I'd like to propose the following RC1 to be released as the > > official > > > > > > > > Apache Avro 1.12.0 release. > > > > > > > > > > > > > > > > The commit id is 35ff8b997738e4d983871902d47bfb67b3250734 > > > > > > > > * This corresponds to the tag: release-1.12.-rc0 > > > > > > > > * > > https://github.com/apache/avro/releases/tag/release-1.12.0-rc0 > > > > > > > > > > > > > > > > The release tarball, signature, and checksums are here > > (revision > > > > > > r64034) > > > > > > > > * https://dist.apache.org/repos/dist/dev/avro/avro-1.12.0-rc0/ > > > > > > > > > > > > > > > > You can find the KEYS file here: > > > > > > > > * https://dist.apache.org/repos/dist/dev/avro/KEYS > > > > > > > > > > > > > > > > Binary artifacts for Java are staged in Nexus here: > > > > > > > > * > > > > > > > > https://repository.apache.org/content/repositories/orgapacheavro-1037/ > > > > > > > > > > > > > > > > This release includes ~500 Jira issues: > > > > > > > > * > > > > > > > > https://issues.apache.org/jira/browse/AVRO-3855?jql=project%3DAVRO%20AND%20fixVersion%3D1.12.0 > > > > > > > > > > > > > > > > The easiest way to test the release is using Docker: > > > > > > > > wget -q > > > > > > > > https://dist.apache.org/repos/dist/dev/avro/avro-1.12.0-rc0/avro-doc-1.12.0.tar.gz > > > > > > > > tar -xvzf avro-src-1.12.0.tar.gz > > > > > > > > ./build.sh docker-test > > > > > > > > > > > > > > > > Please download, verify, and test. This vote will remain open > > for at > > > > > > > > least 72 hours. > > > > > > > > > > > > > > > > [ ] +1 Release this as Apache Avro 1.12.0 > > > > > > > > [ ] 0 > > > > > > > > [ ] -1 Do not release this because... > > > > > > > > > > > > > > > > Regards > > > > > > > > JB > > > > > > > > > > > > > > >
