kojiromike opened a new pull request, #2935:
URL: https://github.com/apache/avro/pull/2935

   https://github.com/apache/avro/pull/2932 fixed one problem, but there were 
others:
   
   1. The existence of a "WTF" field in the record that is not in the schema, 
causing the code to fail. It's not reflected in [the actual 
docs](https://avro.apache.org/docs/1.11.1/getting-started-python/#serializing-and-deserializing-without-code-generation).
   2. The use of text mode for writing binary data. (This is also correct in 
the Getting Started docs.)
   3. Using strings for paths instead of Path objects. This is a minor thing, 
but a tidy practice.
   4. The possibility of a crash causing a resource leak because our example 
doesn't use context managers to close the file. (This is also _incorrect_ in 
the Getting Started docs.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to