asosnovsky opened a new pull request, #2319:
URL: https://github.com/apache/avro/pull/2319
## What is the purpose of the change
- Patched issue where FramedReader resulted in an infinite loop where it
cannot read anything from the response (it was comparing bytes to a string)
- Patched error handling for the Responder:
- Invalid error source: `except` was pointing at `schema.AvroException`
instead of `avro.errors.AvroException`
- "Handshake" was lost for cases where the response could not be read due
to things like "type errors"
- Added some types to responder class
## Verifying this change
This change added tests and can be verified as follows:
- New test cases added
- Type checker for Responder works (while we have tested it in our repo, I
am honestly a bit confused on how to setup the local server with this code base)
## Documentation
- Does this pull request introduce a new feature? NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
