[ 
https://issues.apache.org/jira/browse/AVRO-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571072#comment-17571072
 ] 

ASF subversion and git services commented on AVRO-3547:
-------------------------------------------------------

Commit 0e89c57b9884d25b47136a3f344a96539c05337e in avro's branch 
refs/heads/branch-1.11 from nileyadav
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0e89c57b9 ]

AVRO-3547: Add support for custom attributes in Avro Schema (#1736)

* Add support for custom attributes in Avro Schema

Custom attributes are allowed at field level as per Avro specification : 
https://avro.apache.org/docs/current/spec.html#schemas

But Avro c++ implementation does not support custom attribute at field level.
Update implementation to support custom attribute at field level.

* Add unit tests

* Avro-3547: Apply suggestions from code review

Co-authored-by: Martin Grigorov <marti...@users.noreply.github.com>

* Avro-3547: Fix build errors

* Update lang/c++/impl/CustomFields.cc

Co-authored-by: Martin Grigorov <marti...@users.noreply.github.com>

* Avro-3547: remove unused method

* AVRO-3547: fix build errors and unit test data

* AVRO-3547: Add documentation for CustomFields

Co-authored-by: nileyadav <nileya...@users.noreply.github.com>
Co-authored-by: Martin Grigorov <marti...@users.noreply.github.com>
(cherry picked from commit 61a1cdcd500356726d4995c19c8a4d5d89989b13)


> support custom attribute at field level
> ---------------------------------------
>
>                 Key: AVRO-3547
>                 URL: https://issues.apache.org/jira/browse/AVRO-3547
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: c++
>            Reporter: Nilesh Yadav
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> Custom attributes are allowed at field level as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> But Avro c++ implementation does not support custom attribute at field level.
> e.g. following schema cannot be parsed correctly due to presence of "sqlName" 
> attribute.
> {
>     'doc': 'weather warning',
>     'name': 'weather',
>     'type': 'record',
>     'fields': [
>     {
>         'name': 'station',
>         'type':'string',
>         'sqlName':'abc-@12'
>     },
>     {
>         'name': 'time',
>         'type':'long',
>         'sqlName': '用户名'
>     }]
> }
> Update implementation to support custom attribute at field level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to