[
https://issues.apache.org/jira/browse/AVRO-3471?focusedWorklogId=748272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748272
]
ASF GitHub Bot logged work on AVRO-3471:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/22 20:57
Start Date: 26/Mar/22 20:57
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1623:
URL: https://github.com/apache/avro/pull/1623#discussion_r835811128
##########
File path: lang/csharp/src/apache/main/Util/TimeMicrosecond.cs
##########
@@ -50,17 +51,16 @@ public override object ConvertToBaseValue(object
logicalValue, LogicalSchema sch
{
var time = (TimeSpan)logicalValue;
- if (time > _maxTime)
+ if (time >= _maxTime)
throw new ArgumentOutOfRangeException(nameof(logicalValue), "A
'time-micros' value can only have the range '00:00:00' to '23:59:59'.");
Review comment:
Ok. I will make the ticket when this is approved and merged and will
make the new ticket marked as 12.0. It is not a complicated one so it should be
fairly trivial including the tests. If everyone agrees with the risks of course
we can merge it sooner and make it part of a minor release instead of waiting
for 12.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 748272)
Remaining Estimate: 21h 40m (was: 21h 50m)
Time Spent: 2h 20m (was: 2h 10m)
> Microseconds logical types are rounded to milliseconds
> ------------------------------------------------------
>
> Key: AVRO-3471
> URL: https://issues.apache.org/jira/browse/AVRO-3471
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
> Reporter: Zoltan Csizmadia
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 24h
> Time Spent: 2h 20m
> Remaining Estimate: 21h 40m
>
> Microseconds logical types are rounded to milliseconds
>
> E.g.
> # 1 us is deserialized into 00:00:00, instead of 00:00:00.000001
> # 1234 us is deserialized into 00:00:00.001, instead of 00:00:00.001234
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
