[
https://issues.apache.org/jira/browse/AVRO-3345?focusedWorklogId=718943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718943
]
ASF GitHub Bot logged work on AVRO-3345:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 19:54
Start Date: 01/Feb/22 19:54
Worklog Time Spent: 10m
Work Description: martin-g commented on a change in pull request #1495:
URL: https://github.com/apache/avro/pull/1495#discussion_r796949832
##########
File path: lang/csharp/src/apache/main/File/DataFileConstants.cs
##########
@@ -64,10 +61,13 @@ public class DataFileConstants
/// <summary>
/// Magic bytes at the beginning of an Avro data file.
/// </summary>
- public static byte[] Magic = { (byte)'O',
- (byte)'b',
- (byte)'j',
- Version };
+ public static readonly byte[] Magic =
Review comment:
> The change was formatting.
What do you mean ?
AFAIU `readonly` makes `Magic` a constant, like `final` in Java.
Until now a user can change the value of `Magic` in his/her application.
After this PR it won't be possible anymore. And such application will fail to
compile. This is what I meant by API change.
But I agree that no one is supposed to change the magic bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 718943)
Time Spent: 50m (was: 40m)
> Resolve unnecessary suppression of CA1052 in DataFileConstants
> --------------------------------------------------------------
>
> Key: AVRO-3345
> URL: https://issues.apache.org/jira/browse/AVRO-3345
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This specifically revolves around the byte array Magic. It just needs to be
> marked readonly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
