[
https://issues.apache.org/jira/browse/AVRO-3048?focusedWorklogId=657323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657323
]
ASF GitHub Bot logged work on AVRO-3048:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/21 15:34
Start Date: 29/Sep/21 15:34
Worklog Time Spent: 10m
Work Description: xkrogen commented on pull request #1333:
URL: https://github.com/apache/avro/pull/1333#issuecomment-930290879
Sorry folks, I feel I may have come off in a different way than I intended.
> Please do not involve corporate/enterprise thinking/talking into OSS
project unless your enterprise wants to offer its help!
My point was simply that there are large bases of Avro users who could
benefit from such a fix. My apologies if bringing an enterprise perspective
into the discussion is contrary to the Avro project's normal thought processes.
Noting that large-scale users (particularly if there are several) are
interested in something is fairly common in the other Apache projects I've
worked on, but I recognize that different communities can be very different. I
completely understand that work is volunteer here and I am not expecting
anything, only trying to provide perspective that may not have been considered.
> This is a fair criticism!
Actually I did not mean this as a criticism of the Avro project, I think it
can just as easily be a criticism of enterprise mindsets and upgrade paces :)
But regardless, thank you for starting a discussion!
Your mail has also made me see why my backport request might be a bit larger
than I thought. It sounds like the Avro project has historically not really
done patch releases on non-current minor versions, meaning the scope of the
request has expanded beyond "backport this PR" to "backport this PR and cut a
patch release specifically for this issue." Completely understood if that's too
big of an ask, and I see now why you brought the 1.11.0 release into the
picture. I will follow the dev list discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 657323)
Time Spent: 1h 10m (was: 1h)
> Using builders leads to performance degradation
> -----------------------------------------------
>
> Key: AVRO-3048
> URL: https://issues.apache.org/jira/browse/AVRO-3048
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.9.2, 1.10.1
> Reporter: Peter
> Assignee: Martin Jubelgas
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When you do a .newBuilder() for avro generated classes, this will call
> org.apache.avro.specific.SpecificData.getForSchema:
>
> public static SpecificData getForSchema(Schema reader) {
> if (reader.getType() == Type.RECORD) {
> final String className = getClassName(reader);
> if (className != null) {
> final Class<?> clazz;
> try
> {
> clazz = Class.forName(className);
> return getForClass(clazz); }
> catch (ClassNotFoundException e)
> { return SpecificData.get();
> }
> }
> }
>
> which seems then to seldom find the value inside the try and a lot of
> ClassNotFoundException is thrown.
> Throwing internal exceptions has great performance penalties and in practice
> users of avro 1.9.x. and 1.10.x in high performance applications are forced
> not to use builders.
>
> Information about same problem is also found on:
> [https://forums.databricks.com/questions/50803/orgapacheavrospecificspecificdatagetforschema-sear.html]
> Problem exists on at least 1.9.2 and 1.10.1 (but not on 1.7.x) in OSGI
> environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
