Fokko, as far as workflow goes I’m just asking if it’s ok to start merging PRs that only support 3.5+ after 1.9 “final” goes out.
That would have two consequences: 1. avro-python3-1.9 would work with python3.4 as well as it ever has. 2. Maintenance releases of 1.9 would need to be cut from a 1.9-based branch instead of master, if we want to continue to support 3.4 at that time. On Wed, May 8, 2019 at 16:57 Driesprong, Fokko <[email protected]> wrote: > Michael, after some careful thoughts I think it is too late to remove 3.4 > support in Avro 1.9 since we're passed RC3. I've updated the tickets to > target this for 1.10. > > Cheers, Fokko > > Op ma 6 mei 2019 om 10:32 schreef Driesprong, Fokko <[email protected] > >: > > > +1 from my side > > > > Thanks Michael for reviving this thread again. Since 3.4 isn't officially > > supported anymore, I think it is save to drop support for Avro 1.9 as > well > > to speed up the deprecation process. In practice it will still work > against > > 3.4 until we start using breaking features such as type annotation, > > f-strings etc. > > > > Cheers, Fokko > > > > Op za 4 mei 2019 om 20:47 schreef Rajkumar Natarajan < > [email protected] > > > > > > >> +1 > >> > >> On Sat, May 4, 2019, 2:37 PM sajuukk <[email protected]> wrote: > >> > >> > +1 > >> > > >> > W dniu 04.05.2019 o 16:10, Michael A. Smith pisze: > >> > > Hi, Avro devs, it's time to wake this thread up for a checkpoint. > >> > > > >> > > I glanced at pypi stats today and it looks like 3.4 downloads are > >> usually > >> > > below 1000. More importantly, Python has already EOL'ed python 3.4. > >> Do we > >> > > want to consider python 3.4 support officially dropped as of the 1.9 > >> > > release? > >> > > > >> > > That is, even if python 3.4 happens to work in 1.9 when it is > >> released, > >> > > only versions 3.5 and up will be officially supported? > >> > > > >> > > I don't believe this is terribly controversial, so I'll ask for a > vote > >> > now. > >> > > > >> > > Please reply +1 if you believe that avro-python3 as of 1.9 considers > >> 3.4 > >> > > deprecated. > >> > > Please reply -1 if you believe that in avro-python3 1.9 we should > >> > continue > >> > > to make efforts to work in python 3.4. > >> > > Please reply 0 if you want to make comments, but not vote. > >> > > > >> > > > >> > https://www.apache.org/foundation/voting.html#votes-on-code-modification > >> > > > >> > > > >> > > On Sat, Nov 10, 2018 at 7:42 PM Piotr Gołąb <[email protected]> > >> wrote: > >> > > > >> > >> Hi Michael, > >> > >> > >> > >> Ok, I think it's good idea to drop the Python 3.4 support after the > >> last > >> > >> release of 3.4. We can show deprecation warnings before. By the > way, > >> > this > >> > >> will also be a good opportunity for some refactoring. As for the > >> Avro on > >> > >> Python 2.7, my approach would be just leave it as it is now and > don't > >> > >> introduce new features. > >> > >> > >> > >> Best, > >> > >> Piotr > >> > >> > >> > >> > >> > >> > >> > >> -- > >> > >> Sent from: > >> > >> > http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html > >> > >> > >> > > >> > > >
