[
https://issues.apache.org/jira/browse/AVRO-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698298#comment-16698298
]
ASF GitHub Bot commented on AVRO-2238:
--------------------------------------
Fokko closed pull request #378: [WIP] AVRO-2238 Update Dockerfile base image
from java to openjdk
URL: https://github.com/apache/avro/pull/378
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/share/docker/Dockerfile b/share/docker/Dockerfile
index ec8ac34f4..49f4f9080 100644
--- a/share/docker/Dockerfile
+++ b/share/docker/Dockerfile
@@ -17,7 +17,7 @@
# Dockerfile for installing the necessary dependencies for building Avro.
# See BUILD.txt.
-FROM java:8-jdk
+FROM openjdk:8
WORKDIR /root
@@ -28,6 +28,10 @@ RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
# Install dependencies from packages
RUN apt-get -qq update && \
+ apt-get -qq install software-properties-common apt-transport-https -y && \
+ curl https://packages.sury.org/php/apt.gpg | apt-key add - && \
+ echo "deb https://packages.sury.org/php/ $(lsb_release -sc) main" >
/etc/apt/sources.list.d/php.list && \
+ apt-get -qq update && \
apt-get -qq install --no-install-recommends -y \
ant \
asciidoc \
@@ -46,15 +50,14 @@ RUN apt-get -qq update && \
libglib2.0-dev \
libjansson-dev \
libsnappy-dev \
- libsnappy1 \
make \
maven \
mono-devel \
nodejs \
nunit \
perl \
- php5 \
- php5-gmp \
+ php5.6 \
+ php5.6-gmp \
phpunit \
python \
python-setuptools \
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Docker image from java to openjdk
> ----------------------------------------
>
> Key: AVRO-2238
> URL: https://issues.apache.org/jira/browse/AVRO-2238
> Project: Apache Avro
> Issue Type: Improvement
> Components: docker
> Reporter: Fokko Driesprong
> Priority: Major
>
> Currently the docker image to run the tests is still using java which is
> deprecated: https://hub.docker.com/_/java/
> Therefore we should move to openjdk (https://hub.docker.com/_/openjdk/).
> Starting with version 8, and also adding 10 and 11 to it to make sure that
> Avro is compatible with future version of Java.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
