[
https://issues.apache.org/jira/browse/AVRO-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678423#comment-16678423
]
ASF GitHub Bot commented on AVRO-1808:
--------------------------------------
KonstantinUsachev commented on issue #75: AVRO-1808. Added possibility of
overriding lock mechanics for Requestor.handshakeLock
URL: https://github.com/apache/avro/pull/75#issuecomment-436670848
> @KonstantinUsachev Do you know if this is still relevant?
@Fokko Hi. In our case it was necessary, because we used Avro with Quasar
framework where it is forbidden to use ReentrantLock (it blocks thread instead
of fiber). Don't know, what is the current situation, because we finished our
work with that project. So I don't need it anymore personally and, actually,
don't quite like this PR now :) because in this case we have unused
handshakeLock field. But I will not give any better, so feel free to reject it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> It would be useful to be able to change lock mechanics for handshake at
> Requestor
> ----------------------------------------------------------------------------------
>
> Key: AVRO-1808
> URL: https://issues.apache.org/jira/browse/AVRO-1808
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Konstantin Usachev
> Assignee: Konstantin Usachev
> Priority: Minor
>
> For now there is no option to change lock mechanics for handshake at
> org.apache.avro.ipc.Requestor - it uses ReentrantLock. We can't use this type
> of lock in our system, so we need some way to override it, like the way you
> have already done for org.apache.avro.ipc.Transceiver.channelLock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
