[
https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661131#comment-16661131
]
ASF GitHub Bot commented on AVRO-2090:
--------------------------------------
Fokko commented on issue #350: AVRO-2090 second try
URL: https://github.com/apache/avro/pull/350#issuecomment-432378885
Did you check the tests? I'm trying to set up CI/CD, but the following tests
are failing:
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.avro.specific.TestGeneratedCode
Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 1.353 sec
<<< FAILURE! - in org.apache.avro.specific.TestGeneratedCode
withSchemaMigration(org.apache.avro.specific.TestGeneratedCode) Time
elapsed: 0.042 sec <<< FAILURE!
java.lang.AssertionError: Test schema must allow for custom coders.
at
org.apache.avro.specific.TestGeneratedCode.withSchemaMigration(TestGeneratedCode.java:75)
withoutSchemaMigration(org.apache.avro.specific.TestGeneratedCode) Time
elapsed: 0.001 sec <<< FAILURE!
java.lang.AssertionError: Test schema must allow for custom coders.
at
org.apache.avro.specific.TestGeneratedCode.withoutSchemaMigration(TestGeneratedCode.java:54)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve encode/decode time for SpecificRecord using code generation
> -------------------------------------------------------------------
>
> Key: AVRO-2090
> URL: https://issues.apache.org/jira/browse/AVRO-2090
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Raymie Stata
> Assignee: Raymie Stata
> Priority: Major
> Fix For: 1.9.0
>
> Attachments: customcoders.md, perf-data.txt
>
>
> New implementation for generation of code for SpecificRecord that improves
> decoding by over 10% and encoding over 30% (more improvements are on the
> way). This feature is behind a feature flag
> ({{org.apache.avro.specific.use_custom_coders}}) and (for now) turned off by
> default. See [Getting Started
> (Java)|https://avro.apache.org/docs/current/gettingstartedjava.html#Beta+feature:+Generating+faster+code]
> for instructions.
> (A bit more info: Compared to GenericRecords, SpecificRecords offer
> type-safety plus the performance of traditional getters/setters/instance
> variables. But these are only beneficial to Java code accessing those
> records. SpecificRecords inherit serialization and deserialization code from
> GenericRecords, which is dynamic and thus slow (in fact, benchmarks show that
> serialization and deserialization is _slower_ for SpecificRecord than for
> GenericRecord). This patch extends record.vm to generate custom,
> higher-performance encoder and decoder functions for SpecificRecords.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
