Jacob Tolar created AVRO-2245:
---------------------------------
Summary: Java codec testing improvements
Key: AVRO-2245
URL: https://issues.apache.org/jira/browse/AVRO-2245
Project: Avro
Issue Type: Improvement
Reporter: Jacob Tolar
In the Avro Java implementation, TestBZip2Codec and TestZstandardCodec are both
laughably wrong.
For example, the last lines of TestBZip2Codec:
{code:java}
byte[] outputByteArray = decompressedBuffer.array();
for (int i = 0; i < inputByteSize; i++) {
inputByteArray[i] = outputByteArray[i];
}
{code}
There should be an assertEquals in there not an assignment statement. (And if
you put assertEquals there, the test actually fails...).
I will send a PR that replaces these tests with a correct parametrized test for
all codecs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
