[
https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442897#comment-16442897
]
ASF GitHub Bot commented on AVRO-1340:
--------------------------------------
cutting commented on issue #298: AVRO-1340: Added Enum Defaults and unit tests.
URL: https://github.com/apache/avro/pull/298#issuecomment-382464584
We're almost there. I just looked at the builder integration, and think it
would be better if we instead added defaultSymbol(String) method to
EnumBuilder. We also need javadoc for this new method, and should update the
EnumBuilder example in the SchemaBuilder class javadoc to specify a default
symbol.
Also, we need to update doc/src/content/xdocs/idl.xml to describe enum
defaults. This can be in the "Defining and Enumeration" section. We can
update the example to include a default.
Additional eyes are not required. Folks have the opportunity to follow here
& object. I'll commit this once we're happy with it. We could add an @default
annotation now, or commit this now and add that later, I don't have a strong
feeling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> use default to allow old readers to specify default enum value when
> encountering new enum symbols
> -------------------------------------------------------------------------------------------------
>
> Key: AVRO-1340
> URL: https://issues.apache.org/jira/browse/AVRO-1340
> Project: Avro
> Issue Type: Improvement
> Components: spec
> Environment: N/A
> Reporter: Jim Donofrio
> Priority: Minor
>
> The schema resolution page says:
> > if both are enums:
> > if the writer's symbol is not present in the reader's enum, then an
> error is signalled.
> This makes it difficult to use enum's because you can never add a enum value
> and keep old reader's compatible. Why not use the default option to refer to
> one of enum values so that when a old reader encounters a enum ordinal it
> does not recognize, it can default to the optional schema provided one. If
> the old schema does not provide a default then the older reader can continue
> to fail as it does today.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
