[
https://issues.apache.org/jira/browse/AVRO-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329656#comment-16329656
]
ASF GitHub Bot commented on AVRO-2131:
--------------------------------------
GitHub user jmax01 opened a pull request:
https://github.com/apache/avro/pull/278
AVRO-2131 Modified Schema.parse(JsonNode schema, Names names) to allow
Unions with self referencess.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmax01/avro master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #278
----
commit fbca0c529d7e345dacabc2f693114c980fd08a2a
Author: jmaxwell <jmaxwell@...>
Date: 2018-01-17T22:54:39Z
AVRO-2131 Modified Schema.parse(JsonNode schema, Names names) to allow
Unions with self references.
----
> Records with unions with self references fail to parse.
> -------------------------------------------------------
>
> Key: AVRO-2131
> URL: https://issues.apache.org/jira/browse/AVRO-2131
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.8.1
> Environment: Java 1.8.0_152-b1
> Reporter: Jeff Maxwell
> Priority: Major
>
> Records with unions with self references fail to parse.
> The example below fails to parse with {{"Type not supported: Node"}}
> {code:javascript}
> [
> {
> "namespace": "tree",
> "type": "record",
> "name": "Node",
> "fields": [
> {
> "name": "left",
> "type": [
> "null",
> {
> "type": "Node"
> }
> ],
> "default": null
> },
> {
> "name": "right",
> "type": [
> "null",
> {
> "type": "Node"
> }
> ],
> "default": null
> }
> ]
> }
> ]
> {code}
> When we don't allow nullability it parses successfully:
> {code:javascript}
> [
> {
> "namespace": "tree",
> "type": "record",
> "name": "Node",
> "fields": [
> {
> "name": "left",
> "type": "Node"
> },
> {
> "name": "right",
> "type": "Node"
> }
> ]
> }
> ]
> {code}
> The root cause: When the second element of the union, {{{"type":"Node"}}}, is
> parsed there is no path that can successfully handle the {{JsonNode}}.
> The solution is to add this logic to the {{Schema.parse(JsonNode schema,
> Names names)}} method:
> {code:java}
> } else { //For unions with self reference
> Name nameFromType = new Name(type, names.space);
> if (names.containsKey(nameFromType)) {
> return names.get(nameFromType);
> }
> throw new SchemaParseException("Type not supported: "+type);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
