[
https://issues.apache.org/jira/browse/AVRO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822514#comment-15822514
]
ASF GitHub Bot commented on AVRO-1901:
--------------------------------------
GitHub user benmccann opened a pull request:
https://github.com/apache/avro/pull/188
AVRO-1901: Record named Exception generated bad code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benmccann/avro backport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit adea35074ae0a0e920bab4dd1f5b4ea723d93222
Author: Ben McCann <[email protected]>
Date: 2017-01-13T23:22:57Z
AVRO-1901: Record named Exception generated bad code
----
> creating a record called "Exception" leads to generated code not compiling
> --------------------------------------------------------------------------
>
> Key: AVRO-1901
> URL: https://issues.apache.org/jira/browse/AVRO-1901
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.7, 1.8.1, 1.9.0
> Reporter: radai rosenblatt
> Assignee: Niels Basjes
>
> consider the following *.avsc file:
> {code:title=Exception.avsc}
> {
> "type": "record",
> "name": "Exception",
> "namespace": "com.acme",
> "fields" : [
> {"name": "value", "type": "int"}
> ],
> "doc": "Will not submit to your fascist naming conventions"
> }
> {code}
> the generated java code will contain:
> {code:title=Exception.java}
> ...
> @override
> public Exception build() {
> try {
> ...
> return record;
> } catch (Exception e) { //boom
> throw new org.apache.avro.AvroRuntimeException(e);
> }
> }
> {code}
> which fails to compile because Exception refers to the generated class (which
> does not extend Throwable)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
