[ 
https://issues.apache.org/jira/browse/AVRO-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523842#comment-15523842
 ] 

Doug Cutting commented on AVRO-1918:
------------------------------------

This looks great.  Some comments.

- SpecificCompiler.java now pre-defines four logical type conversions, date, 
time, timestamp and decimal.  These should be listed in package.html.

- It would be better to provide examples of all of the logical types supported 
in the IDL documentation, so also include "date" and "time_ms".

Thanks!

> Improve logical type documentation
> ----------------------------------
>
>                 Key: AVRO-1918
>                 URL: https://issues.apache.org/jira/browse/AVRO-1918
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Gabor Szadovszky
>
> AVRO-1684 added support for logical types.
> It would be good to add to the IDL documentation some examples of how logical 
> types can be used from IDL.
> We should also update the org.apache.avro.specific documentation indicating 
> the now pre-defined logical type mappings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to