[ 
https://issues.apache.org/jira/browse/AVRO-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391744#comment-15391744
 ] 

ASF GitHub Bot commented on AVRO-1886:
--------------------------------------

GitHub user MiroslavCsonka opened a pull request:

    https://github.com/apache/avro/pull/111

    AVRO-1886: Add validation messages

    ### Changes
    * include error messages when validating a payload
    * correct expectation in specs 
(http://ruby-doc.org/stdlib-2.1.0/libdoc/test/unit/rdoc/Test/Unit/Assertions.html#method-i-assert_equal)
    
    Ticket https://issues.apache.org/jira/browse/AVRO-1886

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FundingCircle/avro 
AVRO-1886-validation-messages

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit 97795a9d4aa520b7f0b73737aecdb38db96bca13
Author: Miroslav Csonka <miroslav.csonka.com>
Date:   2016-01-19T12:17:59Z

    AVRO-1886: Add validation messages

----


> Improve error reporting for schema validation
> ---------------------------------------------
>
>                 Key: AVRO-1886
>                 URL: https://issues.apache.org/jira/browse/AVRO-1886
>             Project: Avro
>          Issue Type: Improvement
>          Components: ruby
>            Reporter: Miroslav Csonka
>            Priority: Minor
>
> In Funding Circle we use avro schema to validate some financial data and 
> we've found ourselves wondering what is invalid. We've noticed that avro 
> [does already 
> validation|https://github.com/apache/avro/blob/master/lang/ruby/lib/avro/schema.rb#L94],
>  but does not report what fields are invalid.
>  At this point, we can clearly communicate validation scenarios and avro can 
> be even used as a validation library.
> Little preview of what we've done
> {quote}
>     at .person.houses\[1\].number_of_rooms expected type long, got string 
> with value "not valid at all"
> {quote}
> At this point, our fork is quite outdated so it will take us some time to 
> update it and submit a patch. This is just a question if you would be 
> interested in receiving such a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to