[
https://issues.apache.org/jira/browse/AVRO-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317574#comment-15317574
]
Andy Mok commented on AVRO-1861:
--------------------------------
Another issue is that Jackson always returns a
[DoubleNode|https://fasterxml.github.io/jackson-databind/javadoc/2.2.0/com/fasterxml/jackson/databind/node/DoubleNode.html]
when parsing a floating point number in JSON. This makes sense since JSON
doesn't encode the type of a value so Jackson will assume a Java {{Double}}.
However, I think the Avro library should be smart enough since the type is
encoded in the Schema for a field and try to cast the value to the correct Java
type based on the Avro type.
{noformat}
{
"name" : "float",
"type" : "float",
"doc" : "The default value in Java is actually a Double when trying to parse
this JSON element into an Avro Schema.",
"default" : -1
}
{noformat}
> Avro Schema parser treats Avro float type as Java Double for default values
> ---------------------------------------------------------------------------
>
> Key: AVRO-1861
> URL: https://issues.apache.org/jira/browse/AVRO-1861
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.8.1
> Reporter: Andy Mok
>
> The following code snippet in the [Schema
> class|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/Schema.java]
> shows that we explicitly treat Avro {{FLOAT}} and {{DOUBLE}} as a Java
> {{Double}}.
> {code:java}
> JsonNode defaultValue = field.get("default");
> if (defaultValue != null
> && (Type.FLOAT.equals(fieldSchema.getType())
> || Type.DOUBLE.equals(fieldSchema.getType()))
> && defaultValue.isTextual())
> defaultValue =
> new DoubleNode(Double.valueOf(defaultValue.getTextValue()));
> {code}
> Jackson has support for
> [FloatNode|https://fasterxml.github.io/jackson-databind/javadoc/2.3.0/com/fasterxml/jackson/databind/node/FloatNode.html]
> so why don't we use that?
> This is a problem when someone calls
> [Schema.Field#defaultVal|https://avro.apache.org/docs/1.8.1/api/java/org/apache/avro/Schema.Field.html#defaultVal()]
> for an Avro field with Avro type {{FLOAT}} and they try to typecast the
> object to a Java {{float}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
