[ 
https://issues.apache.org/jira/browse/AVRO-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222809#comment-15222809
 ] 

ASF GitHub Bot commented on AVRO-1809:
--------------------------------------

Github user DrVirtual closed the pull request at:

    https://github.com/apache/avro/pull/76


> I wish to remove optimization from GenericDatumReader.getResolver
> -----------------------------------------------------------------
>
>                 Key: AVRO-1809
>                 URL: https://issues.apache.org/jira/browse/AVRO-1809
>             Project: Avro
>          Issue Type: Wish
>          Components: java
>            Reporter: Konstantin Usachev
>            Priority: Minor
>
> There is an optimization at 
> org.apache.avro.generic.GenericDatumReader.getResolver, when we cache creator 
> thread and it's first returned value. At first, It looks redundant, because 
> it saves three calls to Map.get, which is unmeasurable, especially after 
> Schema's hashcode calculation optimization, made by the same author 
> [~cutting], it's not obvious and adds additional complexity. Also caching of 
> current thread whould be a source of bugs in case of different green threads 
> libraries integration (which, actually, occurred during integration with 
> Quasar).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to