[
https://issues.apache.org/jira/browse/AVRO-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226701#comment-14226701
]
Ryan Blue commented on AVRO-1608:
---------------------------------
The current patch looks fine to me, except for making Name public. I don't see
a good reason to expose a new class in the API that is a convenience wrapper
around String. Why not use Strings instead?
I agree that we should deprecate Schema#addFields. There's not much value in
these changes unless we deprecate all of the mutator methods.
> Deprecate mutator methods on Schema
> -----------------------------------
>
> Key: AVRO-1608
> URL: https://issues.apache.org/jira/browse/AVRO-1608
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.7.7
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 1.7.8
>
> Attachments: AVRO-1608.patch
>
>
> This is a follow on to AVRO-261. It would be good to deprecate
> JsonProperties#addProp, Schema#addAlias, and Schema.Field#addAlias, and
> remove them in 1.8.0. Instead users should use SchemaBuilder, or we could
> also provide overloaded variants of the factory methods on Schema to specify
> properties and aliases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
