----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/#review31278 -----------------------------------------------------------
Mostly formatting comments this round, many of which might be transferable to the rest of the diff. docs/README.md <https://reviews.apache.org/r/16615/#comment59671> Please use "cluster" instead of "datacenter". docs/README.md <https://reviews.apache.org/r/16615/#comment59669> Please remove trailing whitespace throughout all files. Ultimately, the RB diff should show no red columns. docs/README.md <https://reviews.apache.org/r/16615/#comment59672> Can you also note the IRC channel here? #aurora on irc.freenode.net Also, it's probably a good idea to link to the dev mailing list archive: http://mail-archives.apache.org/mod_mbox/incubator-aurora-dev/ docs/README.md <https://reviews.apache.org/r/16615/#comment59670> Only one newline at end of file please. Comment applies to all files in this diff AFAICT. docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59673> Is the "aurora help open" bit necessary? Rather than "due to...", might be better to cite a JIRA issue tracking the fix. docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59674> i'm mostly markdown-ignorant, but can you let markdown do the list indentation for you? http://daringfireball.net/projects/markdown/syntax#list docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59675> Is there a reason the raw anchor tag is here rather than using what appears to be built-in support for them? http://stackoverflow.com/questions/5319754/cross-reference-named-anchor-in-markdown/7335259#7335259 docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59677> (nitpick) Client seems to be deliberately capitalized when preceded by Aurora. is there a convention being followed? i figured 'Aurora' is the proper noun and the qualifier/component would not be considered proper. docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59678> Can intra-doc links help reduce the prose? If the text 'Job keys' linked to the appropriate anchor, the reader will probably be just as compelled to check it out. In fact, i suggest that all section references be formally linked rather than just capitalized. docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59680> Probably best to massage the text to remove 'ads'. How about: west/web-team/test/nginx docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59681> Consider east/west rather than cluster1/cluster2. docs/clientcommands.md <https://reviews.apache.org/r/16615/#comment59682> Formatting nit: can you indent the hyphens so these read more nicely when not html-generated? Also, please use only one space between hyphen and backtick. - Bill Farner On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16615/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 7:19 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Client command hooks doc > > > Resource isolation doc > > > Configuration tutorial > > > User guide doc > > > Configuration file reference > > > Tutorial doc > > > Client commands doc > > > User doc overview > > > Doc images > > > Adding initial image in images directory > > > Diffs > ----- > > docs/README.md PRE-CREATION > docs/clientcommands.md PRE-CREATION > docs/configurationreference.md PRE-CREATION > docs/configurationtutorial.md PRE-CREATION > docs/hooks.md PRE-CREATION > docs/images/CPUavailability.png PRE-CREATION > docs/images/HelloWorldJob.png PRE-CREATION > docs/images/RoleJobs.png PRE-CREATION > docs/images/ScheduledJobs.png PRE-CREATION > docs/images/TaskBreakdown.png PRE-CREATION > docs/images/aurora_hierarchy.png PRE-CREATION > docs/images/killedtask.png PRE-CREATION > docs/images/lifeofatask.png PRE-CREATION > docs/images/runningtask.png PRE-CREATION > docs/images/stderr.png PRE-CREATION > docs/images/stdout.png PRE-CREATION > docs/resourceisolation.md PRE-CREATION > docs/tutorial.md PRE-CREATION > docs/userguide.md PRE-CREATION > > Diff: https://reviews.apache.org/r/16615/diff/ > > > Testing > ------- > > > Thanks, > > Tom Galloway > >
