> On Jan. 6, 2014, 9:30 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 597 > > <https://reviews.apache.org/r/16629/diff/2/?file=415181#file415181line597> > > > > We now have (at least) two places that get the current quota usage for > > a role. Worse yet, i argue that both of these are flawed since they don't > > account for cron jobs (the policy on that probably warrants wider > > discussion). For the time being, i suggest you extract a helper function > > to share between this and QuotaFilter. > > Maxim Khutornenko wrote: > My intention is to completely deprecate QuotaFilter and related. Here is > the original plan (sorry for not communicating it earlier): > 1. Enable quota client checks for job update (client side); > 2. Expose consumed quota info to the client (server side); > 3. Enable quota client checks for job create (client side); > 4. Deploy all changes in prod; > 5. Deprecate (remove) everything but Quotas.java under > org.apache.aurora.scheduler.quota; > > This CR is part 2 from the above plan. Step 3 will also cover cron job > quota checks at creation time. I agree, we would need more discussion around > cron job quota enforcement at task launch (if we ever decide to do so). Does > it make sense? >
I don't see how you could remove (the functionality of) QuotaFilter. How do you intend to enforce quotas otherwise? - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16629/#review31265 ----------------------------------------------------------- On Jan. 4, 2014, 1:53 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16629/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2014, 1:53 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Part 2: Server side changes for the client quota check. > > Note: api.thrift changes are duplicated from part 1: > https://reviews.apache.org/r/16444/ and will race to submission with it. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > 8fb51d69be6d370f9f010c797b2c1205b38a04f5 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > c1a11bdb91c5e764864324d26248d1783af8048b > src/main/thrift/org/apache/aurora/gen/api.thrift > 480b8f472bcfbe547a91c41638250350a0110334 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 91c1c24448092e1b3454844ab8074ed030383594 > > Diff: https://reviews.apache.org/r/16629/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
