----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16444/#review31142 -----------------------------------------------------------
src/main/python/apache/aurora/client/api/quota_check.py <https://reviews.apache.org/r/16444/#comment59498> Done. src/main/python/apache/aurora/client/api/quota_check.py <https://reviews.apache.org/r/16444/#comment59496> You are right - it does not. This was rather a placeholder to communicate the intent to use client quota checks in both create and update. There are no tests yet and it's not wired into create sequence. Dropping it for now to address create path in a separate changelist. src/main/python/apache/aurora/client/api/quota_check.py <https://reviews.apache.org/r/16444/#comment59499> Done. src/main/python/apache/aurora/client/api/updater.py <https://reviews.apache.org/r/16444/#comment59500> I was split on creating a wrapper as it did not seem to add much benefit apart from hiding +/- ops. Going with your suggestion now as a better long term approach (though a bit more involved to account for sum() and mocking specifics). src/test/python/apache/aurora/client/api/test_quota_check.py <https://reviews.apache.org/r/16444/#comment59501> Done. - Maxim Khutornenko On Jan. 3, 2014, 1:23 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16444/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 1:23 a.m.) > > > Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Quota checks should be done outside of populateJobConfig(). This is needed to > properly account for the released resources to prevent failures in job > updates approaching their quota limits. > > Part 1: schema and client related changes. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/BUILD > 9af74e9746500e7b388fc0b7fe7186fca0daefd3 > src/main/python/apache/aurora/client/api/quota_check.py PRE-CREATION > src/main/python/apache/aurora/client/api/updater.py > e364f26005d5194f2c8fea8c267fe2708c59d50b > src/main/python/apache/aurora/client/commands/BUILD > 556d00aab633106a98cbfb4b1ee2d8e755627c04 > src/main/python/apache/aurora/client/commands/core.py > 45204b58ed14fdb83d31afe0fa4598f1b539062b > src/main/thrift/org/apache/aurora/gen/api.thrift > 480b8f472bcfbe547a91c41638250350a0110334 > src/test/python/apache/aurora/client/api/BUILD > c5326752c9841a3f3cb8c9cc57f29f675e345788 > src/test/python/apache/aurora/client/api/test_quota_check.py PRE-CREATION > src/test/python/apache/aurora/client/api/test_updater.py > 5843bb4d3698abc5c4a48ee6eaf2be85e9415a06 > src/test/python/apache/aurora/client/commands/test_update.py > ccc3ee9d97de4373b05ad2de8d88939510c2f052 > > Diff: https://reviews.apache.org/r/16444/diff/ > > > Testing > ------- > > ./pants src/test/python/twitter/aurora/client:all > > > Thanks, > > Maxim Khutornenko > >
