----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16575/ -----------------------------------------------------------
(Updated Jan. 3, 2014, 6:57 p.m.) Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim Khutornenko. Changes ------- Fixed formatting, rebased on master. Repository: aurora Description ------- This change makes it easier to consume events about the state of tasks. Previously, ~every consumer of TaskStateChange needed to know to also consume StorageStarted and query the full storage. The new change makes TaskStateChange more intuitive and therefore less error-prone. A big side-effect of this change is that several classes no longer need to worry about or query Storage. Changes of note: - Most critical change is in CallOrderEnforcingStorage, which now sends a slew of TaskStateChange notifications instead of StorageStarted. This has a ripple for event consumers. - NotifyingMethodInterceptor was removed, as it was easily replaced by more readable and concise code. - Introduced EventSink interface to replace the ambiguous Closure<PubsubEvent> binding. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 90339224919a44e10b17ef81c8a3c437dfdad09c src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java a54c342fd826a9d91e76c7398e2856fe7b29ab74 src/main/java/org/apache/aurora/scheduler/TaskVars.java 32ec93931d45c7e8eb0b8873ba356d336aea9d50 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 462e0dff04b988236bde31f584eebcc03dff757e src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java fb4d2b97c92c268d30680406f698f854ecc09b0e src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 1119344d3ee4637856c7991515506c7a4580a98a src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 4a91d9ffbfccca5266a4b8ce0eafbca1f1e02dad src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 046befb2c966db5aaf09555a4720d225fa404629 src/main/java/org/apache/aurora/scheduler/events/EventSink.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptor.java 8003262d3fb7a790302ff7ea46575767d0b22801 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java e5ab28474dbd93250c42e2db433654b29458f0e4 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 971f40c9dba872fd52042a48a3090ebaf09b990f src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 1260a160495128056d756fb06a91149a15ca9246 src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java f801f804bc9af5570c83fc4f4dbe56c3f5154201 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java e1773e9f59f2c8ea1fcd53e8dc56f41e5f3d3ce2 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 007369c555e29e53dab4603d971914518241a78a src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java 46e1568cb2d72e8f89dc35cf25533b9bc4c06fde src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 0024222980e59707f3af1570e51ac4e0797d7205 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java cdc7ce60c66c2c7416aeb78e09915fcea54f3a7a src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 5937e9dfa57e5da9a0ac670f0b60cc7038f7adbf src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java fc789e7642becc1347843bf80d46c514c367344e src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java f09acfa0e229195cd6df670b3826f05ac626df46 src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java 530254a6d3000771f9c6776fbf06a1c50b367a39 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4c17176a0c265c0bbf5b55a2fdb1fe7eb3f106f7 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 8bc15a46c49d37e2eca86c73ec9fa28a61ca68d4 src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 375b6c28685178c44344ed21c0f1967c2f3b8e53 src/test/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptorTest.java a38d2089d69d0cb29c005a5044cc16547edcc92a src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java ea6d342afc9fb8288c0833a2e657ac01af776fb1 src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 67d909f08a82b8162363e8e1558a6fba75ae09d4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fcd1e26d20f64cec7c549daa1214819a9fab02dd src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java a4425494b807251539087000ba8b058f6312622c src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 3561ce3a96dd59ab481c5a048843a41bcea61ef8 src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java e022767af31d9a4eef25075225e05ac5f6843114 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 2075ed002073390e3bd65f31a24fbf86310327d3 Diff: https://reviews.apache.org/r/16575/diff/ Testing ------- ./gradlew build Thanks, Bill Farner
