----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16444/ -----------------------------------------------------------
Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Repository: aurora Description ------- Quota checks should be done outside of populateJobConfig(). This is needed to properly account for the released resources to prevent failures in job updates approaching their quota limits. Part 1: schema and client related changes. Diffs ----- src/main/python/twitter/aurora/client/api/BUILD 4935b8a5da5621a581a825ea9da913279521ee7b src/main/python/twitter/aurora/client/api/quota_check.py PRE-CREATION src/main/python/twitter/aurora/client/api/updater.py 6e8e8a9fdfcf63a8fe0558d5ac36298601fd0552 src/main/python/twitter/aurora/client/commands/core.py 712c7ea04de61f1d66cab1db5c527c407393ec30 src/main/thrift/com/twitter/aurora/gen/api.thrift 9b3680b7f219e2805bdc37f2e7560cdca41a5913 src/test/python/twitter/aurora/client/api/BUILD 2850ece7280010d86348b2bc001e86258ef217a8 src/test/python/twitter/aurora/client/api/test_quota_check.py PRE-CREATION src/test/python/twitter/aurora/client/api/test_updater.py ae4de2b57be16f8daf030210abda1ba05f9f30a0 src/test/python/twitter/aurora/client/commands/test_update.py 9aa2ba721d5c63803ca09bb3df24dc64f4583f74 Diff: https://reviews.apache.org/r/16444/diff/ Testing ------- ./pants src/test/python/twitter/aurora/client:all Thanks, Maxim Khutornenko
