> On Dec. 17, 2013, 2:06 a.m., Brian Wickman wrote: > > src/main/python/twitter/aurora/client/api/updater.py, line 8 > > <https://reviews.apache.org/r/16310/diff/1/?file=398646#file398646line8> > > > > when deleting deps like this always doublecheck the BUILD -- you can > > remove the src/main/python/twitter/aurora/client:base dep from the updater > > target
Ah, good point. Fixed. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16310/#review30514 ----------------------------------------------------------- On Dec. 17, 2013, 2:02 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16310/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2013, 2:02 a.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Updater prints duplicate LOCK error message in case of held lock. > > > Diffs > ----- > > src/main/python/twitter/aurora/client/api/updater.py > 32bd6a1bf6bf401b0341b6e14e570d83c3e79dd5 > > Diff: https://reviews.apache.org/r/16310/diff/ > > > Testing > ------- > > Tested via local source distribution: > $ dist/aurora_client.pex update smf1-test/mkhutornenko/test/cron_hello_world > aurora/internal/examples/hello_world.aurora > INFO] Updating job: cron_hello_world > INFO] Response from scheduler: LOCK_ERROR (message: Operation for: > mkhutornenko/test/cron_hello_world is already in progress. Started at: Tue > Dec 17 00:56:43 UTC 2013. Current owner: mkhutornenko.) > INFO] > Note: if the scheduler detects that a job update is in progress (or was not > properly completed) it will reject subsequent updates. This is because your > job is likely in a partially-updated state. You should only begin another > update if you are confident that nobody is updating this job, and that > the job is in a state suitable for an update. > > After checking on the above, you may release the update lock on the job by > invoking cancel_update. > > > Thanks, > > Maxim Khutornenko > >
