Thanks! Sadly, I still don't have commit rights, so I can't actually ship it myself. Can one of you guys do it?
-Mark On Mon, Dec 16, 2013 at 12:43 PM, Brian Wickman <wick...@gmail.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16130/ > > Ship it! > > Ship It! > > > - Brian Wickman > > On December 16th, 2013, 4:45 p.m. UTC, Mark Chu-Carroll wrote: > Review request for Aurora, Jonathan Boulle and Brian Wickman. > By Mark Chu-Carroll. > > *Updated Dec. 16, 2013, 4:45 p.m.* > *Repository: * aurora > Description > > First step towards aurora client v2! > > - Initial implementation of the noun/verb command and options processing > framework. > - Initial implementation of a command processing context for aurora commands. > - Implementations of a "Job" noun and "create" and "kill" verbs. > - Tests. > > Note: not all of the v1 tests for the create and kill verbs have been > migrated to the new > framework; command processing contexts need a bit more work to make it easy > to do the > appropriate mocking/stubbing to support them. They'll be in the next change. > > > Diffs > > - src/main/python/twitter/aurora/BUILD.thirdparty > (87156eaa48a39689e18a3190fda487bcfe755771) > - src/main/python/twitter/aurora/client/cli/BUILD (PRE-CREATION) > - src/main/python/twitter/aurora/client/cli/__init__.py (PRE-CREATION) > - src/main/python/twitter/aurora/client/cli/context.py (PRE-CREATION) > - src/main/python/twitter/aurora/client/cli/jobs.py (PRE-CREATION) > - src/test/python/twitter/aurora/client/cli/BUILD (PRE-CREATION) > - src/test/python/twitter/aurora/client/cli/test_create.py > (PRE-CREATION) > - src/test/python/twitter/aurora/client/cli/test_kill.py (PRE-CREATION) > - src/test/python/twitter/aurora/client/cli/util.py (PRE-CREATION) > - src/test/python/twitter/aurora/client/commands/test_kill.py > (3649969c77f992688a7ddbe592eda8d4edb94036) > > View Diff <https://reviews.apache.org/r/16130/diff/> > -- Mark Craig Chu-Carroll *** Software Engineer@Twitter, Software Tools/Programming Language/Math Geek *** Email:mchucarr...@twitter.com / mar...@gmail.com *** Blog: http://scientopia.org/blogs/goodmath