> On Dec. 12, 2013, 4:18 p.m., Bill Farner wrote: > > Meta question — will these numbers always be the same, or do you imagine > > that we will rev them independently? > > Zameer Manji wrote: > They should be same. I think reving them independently leads to insanity. > If a component needs a hotfix (ie executor) we branch from the entire repo > and release everything together. > > Kevin Sweeney wrote: > I think we should only release the components as an atomic unit with a > single version number. This won't be painful with the tooling I describe in > the above comment. > > Bill Farner wrote: > That's the direction i preferred as well. If everyone agrees on that, i > propose we have a single file containing the version ID, with everything > drawing from that. This may require a sacrifice to the gradle gods.
After literally minutes of frantic Googleing, the gods were appeased. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16228/#review30306 ----------------------------------------------------------- On Dec. 12, 2013, 5:27 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16228/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 5:27 p.m.) > > > Review request for Aurora, Bill Farner, Brian Wickman, and Zameer Manji. > > > Bugs: AURORA-10 > https://issues.apache.org/jira/browse/AURORA-10 > > > Repository: aurora > > > Description > ------- > > Pin master to -SNAPSHOT and -dev versions. > > This ensures that we don't inadvertendly publish artifacts that aren't > the final tagged version. A future review will introduce tooling to > automatically and atomically increment these version numbers. > > > Diffs > ----- > > .auroraversion PRE-CREATION > build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9 > src/main/python/twitter/aurora/client/BUILD > a96a801042c2f3d523ee58645a077e47ce9eac38 > src/main/python/twitter/aurora/config/BUILD > 0462158357730865387d0ead001077f39bba6dcb > src/main/python/twitter/aurora/executor/BUILD > 02d34f0354e1452731353bd43e43eed9d034398a > src/main/python/twitter/thermos/BUILD > 7c5d760c863c2f56d6518a0fbb01aa361c0e6db2 > src/main/python/twitter/thermos/common/BUILD > 38de710368dfff46f1dae6df1b878e3d81eb28d3 > src/main/python/twitter/thermos/config/BUILD > 7b889d28d13126c4f003c87c7853a0e9ed4e82a5 > src/main/python/twitter/thermos/core/BUILD > 014b1f7fa3cc45661c194ae8256fe9767530c3b3 > src/main/python/twitter/thermos/monitoring/BUILD > 8601c4eae76aad380274076e7df088c1e8d33ba3 > src/main/python/twitter/thermos/observer/BUILD > 090d3ad33083d5ea51a34af29412134afddcc9e2 > src/main/thrift/com/twitter/aurora/gen/BUILD > a21f2fc796871ff74b1af4852ec298d75458d442 > src/main/thrift/com/twitter/thermos/BUILD > c224d8d5e87f05ea37ac8ecc4ba223228a32b8a5 > > Diff: https://reviews.apache.org/r/16228/diff/ > > > Testing > ------- > > % ./gradlew publishToMavenLocal > Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8 > make: Nothing to be done for `all'. > :generatePomFileForMavenPublication > :bootstrapThrift UP-TO-DATE > :generateSources UP-TO-DATE > :compileGeneratedJava UP-TO-DATE > :processGeneratedResources UP-TO-DATE > :generatedClasses UP-TO-DATE > :compileJava UP-TO-DATE > :processResources UP-TO-DATE > :classes UP-TO-DATE > :jar UP-TO-DATE > :sourceJar UP-TO-DATE > :publishMavenPublicationToMavenLocal > Uploading: > com/twitter/aurora/twitter-aurora/0.2.0-SNAPSHOT/twitter-aurora-0.2.0-20131213.012431-3.jar > to repository remote at file:/Users/ksweeney/.m2/repository/ > Transferring 2577K from remote > Uploaded 2577K > Uploading: > com/twitter/aurora/twitter-aurora/0.2.0-SNAPSHOT/twitter-aurora-0.2.0-20131213.012431-3-sources.jar > to repository remote at file:/Users/ksweeney/.m2/repository/ > Transferring 301K from remote > Uploaded 301K > :publishToMavenLocal > > BUILD SUCCESSFUL > > Total time: 14.31 secs > > % ./pants setup_py src/main/python/twitter/aurora/config:config-packaged > Running "/opt/twitter/opt/python/bin/python2.7 setup.py sdist" in > /Users/ksweeney/workspace/aurora/dist/twitter.aurora.config-0.2.0-snapshot > Wrote > /Users/ksweeney/workspace/aurora/dist/twitter.aurora.config-0.2.0-snapshot.tar.gz > > > Thanks, > > Kevin Sweeney > >
